Bug 129804

Summary: [WebRTC] Updating RTCPeerConnection.idl
Product: WebKit Reporter: Thiago de Barros Lacerda <thiago.lacerda>
Component: WebCore Misc.Assignee: Thiago de Barros Lacerda <thiago.lacerda>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124288, 129845    
Attachments:
Description Flags
Patch
eric.carlson: review+, thiago.lacerda: commit-queue-
Patch for landing none

Thiago de Barros Lacerda
Reported 2014-03-06 08:11:07 PST
Some methods signatures were wrong, marking some arguments as optional when they are mandatory.
Attachments
Patch (13.85 KB, patch)
2014-03-06 16:32 PST, Thiago de Barros Lacerda 		eric.carlson: review+
thiago.lacerda: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (14.06 KB, patch)
2014-03-06 20:51 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2014-03-06 16:32:26 PST
Created attachment 226060 [details] Patch
Eric Carlson
Comment 2 2014-03-06 19:46:26 PST
Comment on attachment 226060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226060&action=review > LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html:40 > + shouldNotThrow('pc.getStats(statsHandler2, statsError, pc.getLocalStreams()[0].getVideoTracks()[0])'); If we don't already have tests to check the error callback, please file a bug so we remember to add them.
Thiago de Barros Lacerda
Comment 3 2014-03-06 20:51:54 PST
Created attachment 226080 [details] Patch for landing
WebKit Commit Bot
Comment 4 2014-03-06 21:37:12 PST
Comment on attachment 226080 [details] Patch for landing Clearing flags on attachment: 226080 Committed r165248: <http://trac.webkit.org/changeset/165248>
Note You need to log in before you can comment on or make changes to this bug.