Bug 129565

Summary:

Remove filterRes parameter from filters

Product:

WebKit

Reporter:

Adenilson Cavalcanti Silva <savagobr>

Component:

CSS

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, felix.hassert+webkit, ideami, krit, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar, WebExposed

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

68469

Attachments:

Description	Flags
test-page to show effect of filterRes on retina clients	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews202 for win-future	none
Archive of layout-test-results from ews116 for mac-sierra	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews202 for win-future	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none

Adenilson Cavalcanti Silva

Reported 2014-03-01 17:27:23 PST

It seems that filterRes is deprecated in the spec (http://dev.w3.org/fxtf/filters/). Quote: "... filterRes attribute was removed from the specification. See SVG 1.1 specification for the definition". Finally FF has removed it already. It makes sense to remove this feature.

Attachments
test-page to show effect of filterRes on retina clients (570.36 KB, application/octet-stream) 2015-12-08 09:27 PST, Felix Hassert	no flags	Details
Patch (580.05 KB, patch) 2018-09-23 10:47 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.63 MB, application/zip) 2018-09-23 11:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.20 MB, application/zip) 2018-09-23 12:06 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews202 for win-future (12.97 MB, application/zip) 2018-09-23 12:30 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.29 MB, application/zip) 2018-09-23 12:49 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.55 MB, application/zip) 2018-09-23 12:53 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (3.24 MB, application/zip) 2018-09-23 14:46 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.57 MB, application/zip) 2018-09-23 15:35 PDT, EWS Watchlist	no flags	Details
Patch (661.32 KB, patch) 2018-09-23 20:18 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews202 for win-future (12.94 MB, application/zip) 2018-09-23 22:03 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.47 MB, application/zip) 2018-09-23 22:24 PDT, EWS Watchlist	no flags	Details
Patch (665.12 KB, patch) 2018-09-23 22:31 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2014-03-02 08:35:35 PST

*** Bug 124914 has been marked as a duplicate of this bug. ***

Felix Hassert

Comment 2 2015-12-08 09:24:58 PST

I stumbled upon very similar problems with SVG Filters that are rendered in Safari in viewport pixels, disregarding device pixels on 'retina' devices. This was reported in Bug 124914 and in a somewhat related discussion in Bug 93471. I am also using filterRes to get sharp images on retina images. I have a test-page attached. The HTML is: <img src="filtered.svg" width="400"> and filtered.svg has a width of 800px for clients with DPR=2. as soon as a filter is used in the SVG it appears blurry in the browser. i can fix that by repeating the (desired) dimensions as filterRes in the svg: <svg .... width="800" height="531" ...> .. <filter filterRes="800 531" id="noop"> ... I don't know of any other workaround to make filters apply on a canvas regarding the dpr. If there is a better and more compliant way, please let me know. However, as long as I need this workaround, I would like to discourage you to drop filterRes. That said, I think that it is a bug in webkit, that the actual canvas size for filters is (presumably) derived from the targeted viewport area. Other browsers (Chrome and Firefox) that have already dropped filterRes support do not show this behavior. Please use the attached test-page svg-filter.tgz to verify it.

Felix Hassert

Comment 3 2015-12-08 09:27:34 PST

Created attachment 266897 [details] test-page to show effect of filterRes on retina clients

Radar WebKit Bug Importer

Comment 4 2018-09-23 10:22:56 PDT

<rdar://problem/44714340>

Simon Fraser (smfr)

Comment 5 2018-09-23 10:47:51 PDT

Created attachment 350573 [details] Patch

EWS Watchlist

Comment 6 2018-09-23 11:54:16 PDT Comment hidden (obsolete)

Comment on attachment 350573 [details] Patch Attachment 350573 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9322431 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html svg/dom/SVGAnimatedInteger.html

EWS Watchlist

Comment 7 2018-09-23 11:54:18 PDT Comment hidden (obsolete)

Created attachment 350578 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-09-23 12:06:23 PDT Comment hidden (obsolete)

Comment on attachment 350573 [details] Patch Attachment 350573 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9322448 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html svg/dom/SVGAnimatedInteger.html

EWS Watchlist

Comment 9 2018-09-23 12:06:25 PDT Comment hidden (obsolete)

Created attachment 350580 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-09-23 12:30:02 PDT Comment hidden (obsolete)

Comment on attachment 350573 [details] Patch Attachment 350573 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9322571 New failing tests: html5lib/generated/run-tests11-write.html html5lib/generated/run-tests11-data.html svg/dom/SVGAnimatedInteger.html svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg

EWS Watchlist

Comment 11 2018-09-23 12:30:14 PDT Comment hidden (obsolete)

Created attachment 350582 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

EWS Watchlist

Comment 12 2018-09-23 12:49:35 PDT Comment hidden (obsolete)

Comment on attachment 350573 [details] Patch Attachment 350573 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9322499 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html svg/dom/SVGAnimatedInteger.html

EWS Watchlist

Comment 13 2018-09-23 12:49:36 PDT Comment hidden (obsolete)

Created attachment 350585 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-09-23 12:53:20 PDT Comment hidden (obsolete)

Comment on attachment 350573 [details] Patch Attachment 350573 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9322506 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html svg/dom/SVGAnimatedInteger.html

EWS Watchlist

Comment 15 2018-09-23 12:53:22 PDT Comment hidden (obsolete)

Created attachment 350586 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 16 2018-09-23 14:46:06 PDT Comment hidden (obsolete)

Comment on attachment 350573 [details] Patch Attachment 350573 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9323346 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html svg/dom/SVGAnimatedInteger.html

EWS Watchlist

Comment 17 2018-09-23 14:46:08 PDT Comment hidden (obsolete)

Created attachment 350589 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 18 2018-09-23 15:35:33 PDT Comment hidden (obsolete)

Comment on attachment 350573 [details] Patch Attachment 350573 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9323436 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg html5lib/generated/run-tests11-write.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests11.html html5lib/generated/run-tests11-data.html svg/dom/SVGAnimatedInteger.html

EWS Watchlist

Comment 19 2018-09-23 15:35:35 PDT Comment hidden (obsolete)

Created attachment 350592 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 20 2018-09-23 20:18:58 PDT

Created attachment 350601 [details] Patch

EWS Watchlist

Comment 21 2018-09-23 22:03:02 PDT Comment hidden (obsolete)

Comment on attachment 350601 [details] Patch Attachment 350601 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9326123 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg

EWS Watchlist

Comment 22 2018-09-23 22:03:14 PDT Comment hidden (obsolete)

Created attachment 350603 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

EWS Watchlist

Comment 23 2018-09-23 22:24:57 PDT Comment hidden (obsolete)

Comment on attachment 350601 [details] Patch Attachment 350601 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9326105 New failing tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg

EWS Watchlist

Comment 24 2018-09-23 22:24:59 PDT Comment hidden (obsolete)

Created attachment 350607 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 25 2018-09-23 22:31:22 PDT

Created attachment 350608 [details] Patch

WebKit Commit Bot

Comment 26 2018-09-24 17:40:22 PDT

Comment on attachment 350608 [details] Patch Clearing flags on attachment: 350608 Committed r236447: <https://trac.webkit.org/changeset/236447>

WebKit Commit Bot

Comment 27 2018-09-24 17:40:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.