Bug 129182

Summary: [WebRTC] Validating RTCConfiguration according to the spec
Product: WebKit Reporter: Thiago de Barros Lacerda <thiago.lacerda>
Component: WebCore Misc.Assignee: Thiago de Barros Lacerda <thiago.lacerda>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, hta, jer.noble, philipj, pnormand, sergio, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124288    
Attachments:
Description Flags
Patch
eric.carlson: review+, thiago.lacerda: commit-queue-
Requested changes none

Thiago de Barros Lacerda
Reported 2014-02-21 16:12:08 PST
Spec states that: - iceServers should not be an empty list - the entry in the configuration dictionary is "urls", instead of "url" - urls can be either a list or a string Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection
Attachments
Patch (62.08 KB, patch)
2014-02-21 16:37 PST, Thiago de Barros Lacerda 		eric.carlson: review+
thiago.lacerda: commit-queue-
DetailsFormatted DiffDiff
Requested changes (62.12 KB, patch)
2014-02-24 12:14 PST, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2014-02-21 16:37:05 PST
Created attachment 224926 [details] Patch
Eric Carlson
Comment 2 2014-02-21 17:04:41 PST
Comment on attachment 224926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224926&action=review I might have missed it, but I don't see any new tests that pass a list of urls. > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:83 > + // Spec says that "urls" can be either a string or a sequence, so we must check for both. > + Vector<String> urlsList; > + String urlString; Nit: this can move down where the variables are used.
Thiago de Barros Lacerda
Comment 3 2014-02-24 12:14:38 PST
Created attachment 225080 [details] Requested changes
WebKit Commit Bot
Comment 4 2014-02-24 12:55:11 PST
Comment on attachment 225080 [details] Requested changes Clearing flags on attachment: 225080 Committed r164602: <http://trac.webkit.org/changeset/164602>
Note You need to log in before you can comment on or make changes to this bug.