Bug 128814

Summary: [CSS Regions] visibility: hidden on a region should hide its content
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebCore Misc.Assignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Test case
none
Patch
none
Patch none

Andrei Bucur
Reported 2014-02-14 07:05:02 PST
Created attachment 224211 [details] Test case See the attached test case.
Attachments
Test case (793 bytes, text/html)
2014-02-14 07:05 PST, Andrei Bucur 		no flags
Details
Patch (4.40 KB, patch)
2014-02-14 08:15 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (4.17 KB, patch)
2014-02-14 08:44 PST, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2014-02-14 08:15:10 PST
Created attachment 224217 [details] Patch
Mihnea Ovidenie
Comment 2 2014-02-14 08:39:05 PST
Comment on attachment 224217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224217&action=review > LayoutTests/fast/regions/visibility-hidden-expected.html:5 > + <meta http-equiv="content-type" content="text/html; charset=UTF-8"> Please remove this meta tag. > LayoutTests/fast/regions/visibility-hidden.html:5 > + <meta http-equiv="content-type" content="text/html; charset=UTF-8"> Ditto. > LayoutTests/fast/regions/visibility-hidden.html:11 > + border: 1px solid red; Do you need the region to have dimensions and border for this test? > LayoutTests/fast/regions/visibility-hidden.html:16 > + margin-top: 0px; Why do you margin-top on this? I doubt that you need it.
Andrei Bucur
Comment 3 2014-02-14 08:44:31 PST
Created attachment 224219 [details] Patch
Mihnea Ovidenie
Comment 4 2014-02-14 08:47:57 PST
Comment on attachment 224219 [details] Patch r=me
WebKit Commit Bot
Comment 5 2014-02-14 09:30:15 PST
Comment on attachment 224219 [details] Patch Clearing flags on attachment: 224219 Committed r164103: <http://trac.webkit.org/changeset/164103>
WebKit Commit Bot
Comment 6 2014-02-14 09:30:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.