Bug 128681

Summary: Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
Product: WebKit Reporter: Sergio Correia (qrwteyrutiyoup) <sergio>
Component: New BugsAssignee: Sergio Correia (qrwteyrutiyoup) <sergio>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, joepeck, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
v2
none
v3
none
v4...
none
v6 - this might build none

Sergio Correia (qrwteyrutiyoup)
Reported 2014-02-12 12:39:52 PST
Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
Attachments
Patch (70.23 KB, patch)
2014-02-12 12:43 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
v2 (90.29 KB, patch)
2014-02-13 09:51 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
v3 (95.30 KB, patch)
2014-02-13 10:52 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
v4... (98.27 KB, patch)
2014-02-13 15:37 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
v6 - this might build (98.30 KB, patch)
2014-02-17 08:13 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sergio Correia (qrwteyrutiyoup)
Comment 1 2014-02-12 12:42:21 PST
Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting WebCore/inspector/*. Besides files in there, a few other files in JavaScriptCore/inspector, WebKit2/WebProcess/WebCoreSupport/ and WebCore/testing were touched.
Sergio Correia (qrwteyrutiyoup)
Comment 2 2014-02-12 12:43:40 PST
Created attachment 223995 [details] Patch
Sergio Correia (qrwteyrutiyoup)
Comment 3 2014-02-13 09:51:11 PST
Created attachment 224081 [details] v2
Sergio Correia (qrwteyrutiyoup)
Comment 4 2014-02-13 10:52:58 PST
Created attachment 224087 [details] v3
Sergio Correia (qrwteyrutiyoup)
Comment 5 2014-02-13 15:37:11 PST
Created attachment 224122 [details] v4...
Sergio Correia (qrwteyrutiyoup)
Comment 6 2014-02-17 08:13:23 PST
Created attachment 224369 [details] v6 - this might build
WebKit Commit Bot
Comment 7 2014-02-17 12:29:53 PST
Comment on attachment 224369 [details] v6 - this might build Clearing flags on attachment: 224369 Committed r164245: <http://trac.webkit.org/changeset/164245>
WebKit Commit Bot
Comment 8 2014-02-17 12:29:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.