Bug 128234

Summary: Make FTL OSR entry something we only try after we've already compiled the function with the FTL and it still got stuck in a loop after that without ever returning like a sensible function oughta have
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: atrick, barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 128039    
Attachments:
Description Flags
work in progress
none
the patch ggaren: review+

Filip Pizlo
Reported 2014-02-04 21:44:29 PST
Patch forthcoming. This appears to still give us a speed-up on the kinds of things that OSR entry is good for, while also eliminating pointless OSR entry compilations on other things.
Attachments
work in progress (11.06 KB, patch)
2014-02-04 21:55 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (11.11 KB, patch)
2014-02-05 22:27 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-04 21:55:25 PST
Created attachment 223211 [details] work in progress Still needs testing. The approach still feels shady.
Filip Pizlo
Comment 2 2014-02-05 22:27:01 PST
Created attachment 223309 [details] the patch
Geoffrey Garen
Comment 3 2014-02-05 22:30:39 PST
Comment on attachment 223309 [details] the patch r=me
Filip Pizlo
Comment 4 2014-02-05 23:32:41 PST
Landed in http://trac.webkit.org/changeset/163517
Note You need to log in before you can comment on or make changes to this bug.