Bug 127852

Summary: [CSS Shapes] Rounded Insets Let Content Overlap Shape
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: bjonesbe, commit-queue, dino, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, webkit-bug-importer, zoltan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124173    
Attachments:
Description Flags
Test case
none
Patch
none
Patch
bjonesbe: review+
Patch for landing none

Bear Travis
Reported 2014-01-29 13:13:57 PST
Created attachment 222591 [details] Test case In some cases, inline content overlaps with insets with a round applied. Appears to depend on the size of the float shape.
Attachments
Test case (1.36 KB, text/html)
2014-01-29 13:13 PST, Bear Travis 		no flags
Details
Patch (8.04 KB, patch)
2014-02-06 11:21 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Patch (8.03 KB, patch)
2014-02-06 11:22 PST, Zoltan Horvath 		bjonesbe: review+
DetailsFormatted DiffDiff
Patch for landing (8.05 KB, patch)
2014-02-06 16:38 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-31 11:04:59 PST
<rdar://problem/15958574>
Zoltan Horvath
Comment 2 2014-02-06 11:21:26 PST
Created attachment 223352 [details] Patch
Zoltan Horvath
Comment 3 2014-02-06 11:22:27 PST
Created attachment 223354 [details] Patch
Bem Jones-Bey
Comment 4 2014-02-06 15:46:57 PST
Comment on attachment 223354 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223354&action=review > Source/WebCore/css/LengthFunctions.h:41 > +FloatSize floatSizeForLengthSize(const LengthSize&, float maxWidth, float maxHeight); I think it's ok as is, but I could see an argument for using a const FloatSize& instead of two floats. I'll leave that call up to you, since I'm not sure if it's better or not.
Zoltan Horvath
Comment 5 2014-02-06 16:38:46 PST
Created attachment 223405 [details] Patch for landing I'm landing it with LayoutSize.
Zoltan Horvath
Comment 6 2014-02-06 16:39:26 PST
I meant FloatSize.
WebKit Commit Bot
Comment 7 2014-02-06 17:16:14 PST
Comment on attachment 223405 [details] Patch for landing Clearing flags on attachment: 223405 Committed r163585: <http://trac.webkit.org/changeset/163585>
WebKit Commit Bot
Comment 8 2014-02-06 17:16:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.