Bug 127831

Summary: Rename notifyRendererOfSelectionChange
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, darin, enrica, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127834    
Attachments:
Description Flags
Cleanup koivisto: review+

Ryosuke Niwa
Reported 2014-01-28 23:36:44 PST
notifyRendererOfSelectionChange doesn't notify renderer EVER. The name comes from the era where shadow DOM was a render tree concept. The sole purpose of this function is to update text form controls' selection cache so it should be named so.
Attachments
Cleanup (6.16 KB, patch)
2014-01-29 00:25 PST, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-01-29 00:25:53 PST
Created attachment 222556 [details] Cleanup
Ryosuke Niwa
Comment 2 2014-01-29 01:27:48 PST
Committed r163012: <http://trac.webkit.org/changeset/163012>
Darin Adler
Comment 3 2014-01-29 10:14:50 PST
Comment on attachment 222556 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=222556&action=review > Source/WebCore/ChangeLog:8 > + Renamed notifyRendererOfSelectionChange to updateSelectionCachesIfSelectionIsInsideTextFormControl. I think that the name updateFormControlSelectionCaches would be better. It’s true that there is nothing to update if the selection is not inside a text form control, but I don’t think that needs to be stated in the function name.
Note You need to log in before you can comment on or make changes to this bug.