Bug 127763

Created attachment 222406 [details] Patch

Attachment 222406 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITCode.h:221: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.h:244: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/DFGExitProfile.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/Repatch.cpp:1497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:7: "JavaScriptCore/ScriptBreakpoint.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/jit/JITOperations.cpp:704: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:165: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1423: llint_throw_stack_overflow_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1433: llint_stack_check_at_vm_entry is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/jit/ArityCheckFailReturnThunks.cpp:62: Declaration has space between type name and * in m_nextSize * 2 [whitespace/declaration] [3] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:654: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:655: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:44: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:45: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:181: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:191: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:7: "JavaScriptCore/RegularExpression.h" already included at Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:7: "JavaScriptCore/ScriptDebugListener.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:3 [build/include] [4] ERROR: Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:7: "JavaScriptCore/ContentSearchUtilities.h" already included at Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGOSRExitBase.h:70: The parameter name "jitType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:130: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:131: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:126: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:356: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:362: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:376: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:378: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:498: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 52 in 293 files If any of these errors are false positives, please file a bug against check-webkit-style.

Looks like ENABLE_C_LOOP is unhappy due to using Interpreter in VM.h

The EFL failure looks like BS.

(In reply to comment #3) > Looks like ENABLE_C_LOOP is unhappy due to using Interpreter in VM.h Specifically in VM::sanitizeStackForVM.

Comment on attachment 222406 [details] Patch Attachment 222406 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6667972764499968 New failing tests: js/large-expressions.html

Created attachment 222412 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 222406 [details] Patch Attachment 222406 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5709166211497984 New failing tests: js/large-expressions.html

Created attachment 222416 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 222406 [details] Patch Attachment 222406 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6735891565379584 New failing tests: js/large-expressions.html

Created attachment 222420 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Comment on attachment 222406 [details] Patch Attachment 222406 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6503878170247168 New failing tests: js/large-expressions.html

Created attachment 222425 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Comment on attachment 222406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222406&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1325 > + unsigned depthLimit; > + unsigned recursionLimit; > + if (canCompile(capabilityLevel)) { > + depthLimit = Options::maximumInliningDepth(); > + recursionLimit = Options::maximumInliningRecursion(); > + } else { > + depthLimit = Options::maximumInliningDepthForMustInline(); > + recursionLimit = Options::maximumInliningRecursionForMustInline(); > + } This part should be removed, because it is dead code as the EFL EWS noticed.

Created attachment 222437 [details] patch for EWS, integrated to the original patch with one more fix

Comment on attachment 222437 [details] patch for EWS, integrated to the original patch with one more fix uploaded to wrong bug

Created attachment 222450 [details] Patch

Attachment 222450 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITCode.h:221: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.h:244: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/DFGExitProfile.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/Repatch.cpp:1497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:7: "JavaScriptCore/ScriptBreakpoint.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/jit/JITOperations.cpp:704: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:165: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/jit/ArityCheckFailReturnThunks.cpp:62: Declaration has space between type name and * in m_nextSize * 2 [whitespace/declaration] [3] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:654: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:655: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:44: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:45: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:181: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:191: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:7: "JavaScriptCore/RegularExpression.h" already included at Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:7: "JavaScriptCore/ScriptDebugListener.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:3 [build/include] [4] ERROR: Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:7: "JavaScriptCore/ContentSearchUtilities.h" already included at Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGOSRExitBase.h:70: The parameter name "jitType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:130: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:131: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:126: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:356: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:362: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:376: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:378: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:498: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 50 in 293 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 222463 [details] Patch

Attachment 222463 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 19 in 289 files If any of these errors are false positives, please file a bug against check-webkit-style.

(In reply to comment #19) > Created an attachment (id=222463) [details] > Patch I'm not sure why Windows is failing.

(In reply to comment #21) > (In reply to comment #19) > > Created an attachment (id=222463) [details] [details] > > Patch > > I'm not sure why Windows is failing. From the build output it looks like we don't do anything when compiling the JavaScriptCore target.

Created attachment 222468 [details] Patch

Attachment 222468 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 19 in 289 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 222468 [details] Patch Attachment 222468 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5369286860210176 New failing tests: js/large-expressions.html

Created attachment 222477 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Created attachment 222496 [details] Updated patch that build with ENABLE_LLINT_C_LOOP=1 Believe this will fix Windows build, but want to see what the EWS says.

Attachment 222496 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:67: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:174: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 20 in 214 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 222516 [details] Patch with added missing files Prior patch with new files added back in.

Attachment 222516 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:67: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:174: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 20 in 288 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 222524 [details] Updated patch with speculative build fix for Windows

Attachment 222524 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:67: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:174: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:178: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 20 in 288 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 222524 [details] Updated patch with speculative build fix for Windows r=me

Committed r163027: <http://trac.webkit.org/changeset/163027>

(In reply to comment #34) > Committed r163027: <http://trac.webkit.org/changeset/163027> Following this patch. 500+ layout test failures on Windows http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/42167/steps/layout-test/logs/stdio Also JSC tests don't run. After some investigating: It's testapi that's failing. Testapi.c Ln 1602 ASSERT(JSValueIsObject(context, result)); The script silently stops which is why we don't see any output on the bots.

Filed bug for Windows failures: https://bugs.webkit.org/process_bug.cgi

This caused all media support in the Windows port to break.