Bug 127665

Summary: WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, joepeck, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix andersca: review+, commit-queue: commit-queue-

Joseph Pecoraro
Reported 2014-01-26 17:40:04 PST
Looks like this catches some legit bugs. Only a few instances.
Attachments
[PATCH] Proposed Fix (3.03 KB, patch)
2014-01-26 17:44 PST, Joseph Pecoraro 		andersca: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-01-26 17:44:08 PST
Created attachment 222294 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2014-01-26 18:45:13 PST
Comment on attachment 222294 [details] [PATCH] Proposed Fix Rejecting attachment 222294 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/DynamicLinkerEnvironmentExtractor.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/UniqueIDBDatabase.o DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/5370354696454144
Joseph Pecoraro
Comment 3 2014-01-26 19:06:45 PST
Looks like this needs the JSC patch to land before it can land. I will land manually tomorrow.
Darin Adler
Comment 4 2014-01-27 10:50:31 PST
Comment on attachment 222294 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222294&action=review > Source/WebKit2/Shared/UserData.cpp:157 > case API::Object::Type::Point: > static_cast<const API::Point&>(object).encode(encoder); > + break; > > case API::Object::Type::Rect: > static_cast<const API::Rect&>(object).encode(encoder); > + break; Wow, it caught a real bug!
Joseph Pecoraro
Comment 5 2014-01-27 20:12:25 PST
Landed <http://trac.webkit.org/changeset/162909>
Note You need to log in before you can comment on or make changes to this bug.