Bug 127617

Summary: [CSS Shapes] inset() function with multiple spaces on element style
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: betravis, bjonesbe, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, rwlbuis, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124173    
Attachments:
Description Flags
Patch
krit: review+, krit: commit-queue-
Patch for landing none

Dirk Schulze
Reported 2014-01-25 04:22:23 PST
Additional spaces after defining the inset parameters dependent how many parameters have been specified inset(2px) gets to inset(2px ) - three spaces inset(2px 2px) gets to inset(2px 2px 2px ) - two spaces inset(2px 2px 2px) gets to inset(2px 2px 2px ) - one space element style: element.style.webkitShapeInside = "inset(2px)"
Attachments
Patch (24.07 KB, patch)
2014-01-25 09:28 PST, Zoltan Horvath 		krit: review+
krit: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (24.02 KB, patch)
2014-01-27 10:22 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2014-01-25 09:28:15 PST
Created attachment 222212 [details] Patch
Dirk Schulze
Comment 2 2014-01-25 12:12:29 PST
Comment on attachment 222212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222212&action=review r=me with comments. > Source/WebCore/css/CSSBasicShapes.cpp:428 > + if (!right.isNull()) { > + result.appendLiteral(separator); > + result.append(right); > + if (!bottom.isNull()) { > + result.appendLiteral(separator); > + result.append(bottom); > + if (!left.isNull()) { > + result.appendLiteral(separator); > + result.append(left); > + } > + } > + } I don't think that it needs to be nested... At this point we should be able to rely on sane data, shouldn't we? Of course we would have some extra checks though. I leaf it up to you. > Source/WebCore/css/CSSBasicShapes.cpp:444 > + result.append("/"); s/"/'/g
Zoltan Horvath
Comment 3 2014-01-27 10:22:31 PST
Created attachment 222334 [details] Patch for landing
WebKit Commit Bot
Comment 4 2014-01-27 11:10:52 PST
Comment on attachment 222334 [details] Patch for landing Clearing flags on attachment: 222334 Committed r162848: <http://trac.webkit.org/changeset/162848>
WebKit Commit Bot
Comment 5 2014-01-27 11:10:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.