Bug 127580

Summary: Replace LayoutUnit() calls to a more descriptive LayoutUnit::fromPixel(int).
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127562    
Bug Blocks:    
Attachments:
Description Flags
Patch none

alan
Reported 2014-01-24 13:30:45 PST
LayoutUnit(1) is highly ambiguous. It is intended to set one (CSS) pixel, but it could read as 1 layout unit (1/64th of pixel atm)
Attachments
Patch (9.95 KB, patch)
2014-01-24 14:23 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-01-24 14:23:40 PST
Created attachment 222155 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-24 16:17:31 PST
Comment on attachment 222155 [details] Patch Clearing flags on attachment: 222155 Committed r162737: <http://trac.webkit.org/changeset/162737>
WebKit Commit Bot
Comment 3 2014-01-24 16:17:33 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2014-01-28 00:43:08 PST
<rdar://problem/15923398>
Note You need to log in before you can comment on or make changes to this bug.