Bug 126854

Summary:

Remove String::deprecatedCharacters

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

126870, 130197, 130304, 130305, 130317, 130318, 130323, 130515, 130602

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch	none
Patch	none
Patch	sam: review+

Darin Adler

Reported 2014-01-12 14:35:52 PST

Reduce use of String::characters

Attachments
Patch (39.52 KB, patch) 2014-01-12 14:58 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (538.15 KB, application/zip) 2014-01-12 23:12 PST, Build Bot	no flags	Details
Patch (138.02 KB, patch) 2014-03-21 20:20 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (139.93 KB, patch) 2014-03-21 21:04 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (633.31 KB, application/zip) 2014-03-22 00:13 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (598.02 KB, application/zip) 2014-03-22 00:49 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (639.14 KB, application/zip) 2014-03-22 01:24 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (597.20 KB, application/zip) 2014-03-22 01:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (636.64 KB, application/zip) 2014-03-22 02:24 PDT, Build Bot	no flags	Details
Patch (140.09 KB, patch) 2014-03-22 08:01 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (140.07 KB, patch) 2014-03-22 10:53 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (142.31 KB, patch) 2014-03-22 11:31 PDT, Darin Adler	sam: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2014-01-12 14:58:02 PST

Created attachment 220985 [details] Patch

Sam Weinig

Comment 2 2014-01-12 15:15:06 PST

Comment on attachment 220985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220985&action=review > Source/WebCore/editing/CompositeEditCommand.cpp:674 > for (unsigned i = 0; i < text.length(); ++i) { > - if (!isWhitespace(text.characters()[i])) > + if (!isWhitespace(text[i])) > return false; > } > - > return true; > } Could this use isAllSpecialCharacters?

Darin Adler

Comment 3 2014-01-12 15:19:42 PST

Committed r161840: <http://trac.webkit.org/changeset/161840>

WebKit Commit Bot

Comment 4 2014-01-12 22:20:06 PST

Re-opened since this is blocked by bug 126870

Build Bot

Comment 5 2014-01-12 23:12:42 PST

Comment on attachment 220985 [details] Patch Attachment 220985 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6520798932107264 New failing tests: editing/execCommand/indent-pre-list.html editing/execCommand/indent-pre-paragraphs.html editing/deleting/2610675-1.html editing/deleting/merge-whitespace-pre.html fast/forms/textarea-paste-newline.html editing/execCommand/format-block-multiple-paragraphs-in-pre.html editing/pasteboard/copy-image-with-alt-text.html editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html editing/execCommand/format-block-multiple-paragraphs.html editing/pasteboard/copy-paste-pre-line-content.html editing/execCommand/indent-pre.html

Build Bot

Comment 6 2014-01-12 23:12:44 PST

Created attachment 221010 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Darin Adler

Comment 7 2014-03-21 20:20:50 PDT

Created attachment 227526 [details] Patch

Darin Adler

Comment 8 2014-03-21 21:04:45 PDT

Created attachment 227532 [details] Patch

Build Bot

Comment 9 2014-03-22 00:13:07 PDT

Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6313068174770176 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html platform/mac/accessibility/search-predicate.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html

Build Bot

Comment 10 2014-03-22 00:13:10 PDT

Created attachment 227537 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 11 2014-03-22 00:49:02 PDT

Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6495832186552320 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html

Build Bot

Comment 12 2014-03-22 00:49:05 PDT

Created attachment 227539 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 13 2014-03-22 01:24:43 PDT

Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5330893174472704 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html platform/mac/accessibility/search-predicate.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html

Build Bot

Comment 14 2014-03-22 01:24:46 PDT

Created attachment 227540 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 15 2014-03-22 01:45:07 PDT

Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6094294083436544 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html

Build Bot

Comment 16 2014-03-22 01:45:10 PDT

Created attachment 227543 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 17 2014-03-22 02:24:04 PDT

Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5112592603283456 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html platform/mac/accessibility/search-predicate.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html

Build Bot

Comment 18 2014-03-22 02:24:07 PDT

Created attachment 227545 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Darin Adler

Comment 19 2014-03-22 06:52:06 PDT

There was a mistake in LinkHash.cpp that caused all those visited-link tests to fail. I have that fixed now. The mysterious failure is platform/mac/accessibility/search-predicate.html; looking into that next.

Darin Adler

Comment 20 2014-03-22 08:01:14 PDT

Created attachment 227550 [details] Patch

Darin Adler

Comment 21 2014-03-22 10:53:30 PDT

Created attachment 227554 [details] Patch

Darin Adler

Comment 22 2014-03-22 11:31:44 PDT

Created attachment 227556 [details] Patch

Sam Weinig

Comment 23 2014-03-22 11:51:26 PDT

Comment on attachment 227556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227556&action=review > Source/WebCore/platform/URL.cpp:1501 > +static bool containsOnlyASCII(StringView string) > +{ > + if (string.is8Bit()) > + return charactersAreAllASCII(string.characters8(), string.length()); > + return charactersAreAllASCII(string.characters16(), string.length()); > +} We should probably add a version of charactersAreAllASCII() that takes a StringView.

Darin Adler

Comment 24 2014-03-22 11:52:48 PDT

Committed r166120: <http://trac.webkit.org/changeset/166120>

Note You need to log in before you can comment on or make changes to this bug.