Bug 126656

Summary:	Subpixel layout: RenderSearchField and RenderTextControlSingleLine() needs bias centering.
Product:	WebKit	Reporter:	zalan <zalan>
Component:	Layout and Rendering	Assignee:	zalan <zalan>
Status:	RESOLVED INVALID
Severity:	Normal	CC:	jonlee, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	126283

zalan

Reported 2014-01-08 12:47:02 PST

This is similar to bug 125659 with even more bias centering. (probably should merge them) innerTextRenderer->setLogicalTop(innerTextRenderer->logicalTop() - (logicalHeightDiff / 2 + layoutMod(logicalHeightDiff, 2))); failed cases: fast/block/float/032.html fast/forms/search-vertical-alignment.html fast/ruby/ruby-svg-crash.html

Attachments
Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2014-01-08 15:26:53 PST

Check FF, prefer subpixel.

Radar WebKit Bug Importer

Comment 2 2014-01-14 10:24:01 PST

<rdar://problem/15815537>

zalan

Comment 3 2014-01-14 16:15:21 PST

FF renders search widgets differently (search-vertical-alignment.html). The other 2 failed cases are not related and most likely result of some flakiness. Prefer new behavior.

Note You need to log in before you can comment on or make changes to this bug.