Bug 125831

Summary: Fix PlacedFloatsTree to not require truncation of the interval endpoints
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fujii.hironori, glenn, kondapallykalyan, pdr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=249571
https://bugs.webkit.org/show_bug.cgi?id=124506
Attachments:
Description Flags
WIP patch
ews-feeder: commit-queue-
WIP patch ews-feeder: commit-queue-

Bem Jones-Bey
Reported 2013-12-16 21:54:57 PST
While the PlacedFloatsTree uses LayoutUnits, when the intervals are added for a floating object, the endpoints of the interval are floored before being added to the tree. This is the way to not lose the fix from Bug 112744 when a float has a fractional height that is an exact multiple of the line height. There really should be a better solution that doesn't require this truncation.
Attachments
WIP patch (1.19 KB, patch)
2022-12-21 22:49 PST, Fujii Hironori 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP patch (41.89 KB, patch)
2022-12-22 22:18 PST, Fujii Hironori 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-12-21 22:49:45 PST
Created attachment 464162 [details] WIP patch
Fujii Hironori
Comment 2 2022-12-22 22:18:12 PST
Created attachment 464172 [details] WIP patch
Note You need to log in before you can comment on or make changes to this bug.