Bug 125785

Summary: Additional refinement in MathMLSelectElement toggle implementation
Product: WebKit Reporter: Darin Adler <darin>
Component: MathMLAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbarton, fred.wang, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 120059    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2013-12-16 10:17:18 PST
Additional refinement in MathMLSelectElement toggle implementation
Attachments
Patch (5.05 KB, patch)
2013-12-16 10:19 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-12-16 10:19:26 PST
Created attachment 219326 [details] Patch
Darin Adler
Comment 2 2013-12-16 10:21:55 PST
Comment on attachment 219326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review > Source/WebCore/mathml/MathMLSelectElement.cpp:161 > // We update the attribute value of the selection attribute. > // This will also call MathMLSelectElement::attributeChanged to update the selected child. I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part.
Andreas Kling
Comment 3 2013-12-18 02:18:12 PST
Comment on attachment 219326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review r=me >> Source/WebCore/mathml/MathMLSelectElement.cpp:161 >> // This will also call MathMLSelectElement::attributeChanged to update the selected child. > > I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. Your choice. Leaving cq? set.
Darin Adler
Comment 4 2013-12-18 09:32:08 PST
Comment on attachment 219326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review >>> Source/WebCore/mathml/MathMLSelectElement.cpp:161 >>> // This will also call MathMLSelectElement::attributeChanged to update the selected child. >> >> I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. > > Your choice. Leaving cq? set. I’ll come back and do that later.
WebKit Commit Bot
Comment 5 2013-12-18 09:58:56 PST
Comment on attachment 219326 [details] Patch Clearing flags on attachment: 219326 Committed r160771: <http://trac.webkit.org/changeset/160771>
WebKit Commit Bot
Comment 6 2013-12-18 09:58:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.