Bug 124495

Summary: [Performance tests] Interactive/SelectAll.html throws an exception
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124496    
Attachments:
Description Flags
Fixes the bug
none
Added Reviewed by line none

Ryosuke Niwa
Reported 2013-11-18 04:55:59 PST
Interactive/SelectAll.html throws an exception because runTest doesn't stop gracefully after reaching 20 iterations. Return a boolean indicating whether more values are needed or not in PerfTestRunner.measureValueAsync to fix this bug.
Attachments
Fixes the bug (2.59 KB, patch)
2013-11-18 05:00 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added Reviewed by line (2.63 KB, patch)
2013-11-18 05:02 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-11-18 05:00:51 PST
Created attachment 217190 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2013-11-18 05:02:44 PST
Created attachment 217191 [details] Added Reviewed by line
WebKit Commit Bot
Comment 3 2013-11-18 07:26:28 PST
Comment on attachment 217191 [details] Added Reviewed by line Clearing flags on attachment: 217191 Committed r159421: <http://trac.webkit.org/changeset/159421>
WebKit Commit Bot
Comment 4 2013-11-18 07:26:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.