Bug 124416

Summary: [CSS Shapes] Refactor RectangleShape
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124368    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2013-11-15 09:29:43 PST
Currently RectangleShape includes a FloatRoundedRect class which is effectively private. To make way for a public FloatRoundedRect class, which will be the basis for both RectangleShape and TBD BoxShape, the existing FloatRoundedRect class should be renamed and made private to RectangleShape.
Attachments
Patch (8.60 KB, patch)
2013-11-15 10:47 PST, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-11-15 10:47:28 PST
Created attachment 217064 [details] Patch Privatize and rename the FloatRoundedRect class defined in RectangleShape.h. The new class is called RectangleShape::ShapeBounds. This change enables creating a proper FloatRoundedRect analog of the existing RoundedRect class; part of adding support for box shapes, per the latest CSS spec (see https://bugs.webkit.org/show_bug.cgi?id=124368).
WebKit Commit Bot
Comment 2 2013-11-19 12:13:18 PST
Comment on attachment 217064 [details] Patch Clearing flags on attachment: 217064 Committed r159513: <http://trac.webkit.org/changeset/159513>
WebKit Commit Bot
Comment 3 2013-11-19 12:13:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.