Bug 123304

Summary: Result of focus-option-control-on-page.html depends on system preferences
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Simon Fraser (smfr)
Reported 2013-10-24 18:02:24 PDT
focus-option-control-on-page.html depends on your Full Keyboard Access system prefs. Marking it [ Pass Failure ]
Attachments
proposed fix (8.66 KB, patch)
2013-10-29 22:58 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-25 00:25:23 PDT
This is not as easy as I hoped - this is not a global preference, but one in com.apple.universalaccess domain, so we can't just override it AFAIK. Will probably need to add SPI to WK1 and WK2 to bypass reading the actual preference.
Alexey Proskuryakov
Comment 2 2013-10-29 22:58:38 PDT
Created attachment 215474 [details] proposed fix
WebKit Commit Bot
Comment 3 2013-10-29 23:50:36 PDT
The commit-queue encountered the following flaky tests while processing attachment 215474 [details]: media/track/track-text-track-cue-list.html bug 123497 (authors: annacc@chromium.org and eric.carlson@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2013-10-29 23:51:49 PDT
Comment on attachment 215474 [details] proposed fix Clearing flags on attachment: 215474 Committed r158256: <http://trac.webkit.org/changeset/158256>
WebKit Commit Bot
Comment 5 2013-10-29 23:51:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.