Bug 123079

Summary: Simplify TempRegisterSet - it no longer needs to be convertible to a POD since it's no longer going to be a member of a union
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: atrick, barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 123076    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2013-10-19 21:35:22 PDT
A long long time ago, when TempRegisterSet was called RegisterSet and the DFG and baseline JIT had separate codepaths for inline caching, the RegisterSet was stored in a union in StructureStubInfo and so had to have a POD version of itself. None of that is true anymore, so the POD support is just superfluous.
Attachments
the patch (3.00 KB, patch)
2013-10-19 21:36 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-10-19 21:36:20 PDT
Created attachment 214689 [details] the patch
Geoffrey Garen
Comment 2 2013-10-19 22:35:12 PDT
Comment on attachment 214689 [details] the patch R=ME
Filip Pizlo
Comment 3 2013-10-19 22:39:47 PDT
Landed in http://trac.webkit.org/changeset/157696
Note You need to log in before you can comment on or make changes to this bug.