Bug 123077

Summary:

Rename RegisterSet to TempRegisterSet

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

atrick, barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mitz, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

123076

Attachments:

Description	Flags
the patch	none
the patch	mitz: review+
the patch	none

Filip Pizlo

Reported 2013-10-19 20:46:29 PDT

Patch forthcoming.

Attachments
the patch (24.46 KB, patch) 2013-10-19 20:47 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (29.69 KB, patch) 2013-10-19 20:55 PDT, Filip Pizlo	mitz: review+	Details Formatted Diff Diff
the patch (29.71 KB, patch) 2013-10-19 20:56 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-10-19 20:47:15 PDT

Created attachment 214685 [details] the patch

mitz

Comment 2 2013-10-19 20:52:04 PDT

Comment on attachment 214685 [details] the patch I think you need to update the Xcode project reference to this file, and maybe other build systems that reference headers.

Filip Pizlo

Comment 3 2013-10-19 20:54:55 PDT

(In reply to comment #2) > (From update of attachment 214685 [details]) > I think you need to update the Xcode project reference to this file, and maybe other build systems that reference headers. Oh yeah, good point :-)

WebKit Commit Bot

Comment 4 2013-10-19 20:55:35 PDT

Attachment 214685 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/StructureStubInfo.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.h', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/jit/RegisterSet.h', u'Source/JavaScriptCore/jit/ScratchRegisterAllocator.h', u'Source/JavaScriptCore/jit/TempRegisterSet.h']" exit_code: 1 Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:58: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/bytecode/StructureStubInfo.h:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 5 2013-10-19 20:55:54 PDT

Created attachment 214686 [details] the patch

Filip Pizlo

Comment 6 2013-10-19 20:56:52 PDT

Created attachment 214687 [details] the patch

WebKit Commit Bot

Comment 7 2013-10-19 20:58:25 PDT

Attachment 214687 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/bytecode/StructureStubInfo.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp', u'Source/JavaScriptCore/jit/JITInlineCacheGenerator.h', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/jit/RegisterSet.h', u'Source/JavaScriptCore/jit/ScratchRegisterAllocator.h', u'Source/JavaScriptCore/jit/TempRegisterSet.h']" exit_code: 1 Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:58: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 8 2013-10-19 21:11:01 PDT

Landed in http://trac.webkit.org/changeset/157693

Filip Pizlo

Comment 9 2013-10-19 21:11:44 PDT

Comment on attachment 214687 [details] the patch r=mitz, since this is almost an identical patch.

Note You need to log in before you can comment on or make changes to this bug.