Bug 122974

Summary: Remove saving callFrameRegister to JITStackFrame in JITCompiler::compileFunction()
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 121756    
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2013-10-17 11:04:44 PDT
This is no longer needed as the stack check and arity check are now operations. Change is to delete two instances of move(stackPointerRegister, GPRInfo::argumentGPR0); poke(GPRInfo::callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof(void*)); in Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
Attachments
Patch (2.23 KB, patch)
2013-10-17 11:32 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-10-17 11:32:08 PDT
Created attachment 214475 [details] Patch
Geoffrey Garen
Comment 2 2013-10-17 11:46:34 PDT
Comment on attachment 214475 [details] Patch r=me
Michael Saboff
Comment 3 2013-10-17 11:56:07 PDT
Committed r157586: <http://trac.webkit.org/changeset/157586>
Note You need to log in before you can comment on or make changes to this bug.