Bug 122426

Summary: results.html doesn't support non-HTML reference tests or references with external resources
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
patch rniwa: review+

Tim Horton
Reported 2013-10-06 14:41:03 PDT
The layout test harness links to -expected and -expected-mismatch files in WebKitBuild/*/layout-test-results, not in LayoutTests/, so if they reference external files, they will be missing. Also, it explicitly links to -expected.html and -expected-mismatch.html, meaning that the link is broken for SVG ref tests. I have a patch.
Attachments
patch (3.58 KB, patch)
2013-10-06 14:44 PDT, Tim Horton 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (472.27 KB, application/zip)
2013-10-06 15:35 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (483.50 KB, application/zip)
2013-10-06 15:52 PDT, Build Bot 		no flags
Details
patch (4.72 KB, patch)
2013-10-06 16:37 PDT, Tim Horton 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-10-06 14:44:31 PDT
Created attachment 213528 [details] patch
Build Bot
Comment 2 2013-10-06 15:35:29 PDT
Comment on attachment 213528 [details] patch Attachment 213528 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3484085 New failing tests: fast/harness/results.html
Build Bot
Comment 3 2013-10-06 15:35:30 PDT
Created attachment 213531 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2013-10-06 15:52:19 PDT
Comment on attachment 213528 [details] patch Attachment 213528 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3487090 New failing tests: fast/harness/results.html
Build Bot
Comment 5 2013-10-06 15:52:20 PDT
Created attachment 213533 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Tim Horton
Comment 6 2013-10-06 16:37:30 PDT
Created attachment 213539 [details] patch
Tim Horton
Comment 7 2013-10-06 20:58:49 PDT
http://trac.webkit.org/changeset/157020
Alexey Proskuryakov
Comment 8 2013-10-06 21:03:00 PDT
So what does this fix, just local results? Are results on buildbot still broken in the same way as before?
Tim Horton
Comment 9 2013-10-06 21:06:58 PDT
(In reply to comment #8) > So what does this fix, just local results? Are results on buildbot still broken in the same way as before? AFAIK results.html is used for the results saved from the bots as well; references will now (when needed) point to trac instead of the result directory, so they should be able to load external resources now.
Tim Horton
Comment 10 2013-10-06 21:07:17 PDT
(In reply to comment #9) > (In reply to comment #8) > > So what does this fix, just local results? Are results on buildbot still broken in the same way as before? > > AFAIK results.html is used for the results saved from the bots as well; references will now (when needed) point to trac instead of the result directory, so they should be able to load external resources now. Note that I have not tested this, but I will when the bots cycle.
Note You need to log in before you can comment on or make changes to this bug.