Bug 122318

Summary: FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and stack layout
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 113647, 116189, 122487, 122739, 123219    
Bug Blocks: 112840    
Attachments:
Description Flags
LLVM trunk patch to support new webkit intrinsics.
none
rebased LLVM patch
none
the patch
none
the patch ggaren: review+

Filip Pizlo
Reported 2013-10-03 22:00:28 PDT
Patch and further description forthcoming.
Attachments
LLVM trunk patch to support new webkit intrinsics. (32.47 KB, patch)
2013-10-04 11:12 PDT, Andrew Trick 		no flags
DetailsFormatted DiffDiff
rebased LLVM patch (48.73 KB, patch)
2013-10-07 11:39 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (33.22 KB, patch)
2013-11-02 20:18 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (33.99 KB, patch)
2013-11-02 20:54 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andrew Trick
Comment 1 2013-10-04 11:12:28 PDT
Created attachment 213378 [details] LLVM trunk patch to support new webkit intrinsics.
Filip Pizlo
Comment 2 2013-10-07 11:39:40 PDT
Created attachment 213605 [details] rebased LLVM patch Just rebasing.
Mark Rowe (bdash)
Comment 3 2013-10-09 02:37:00 PDT
Probably worth using the correct spellings of JavaScript and WebKit in the comments within the LLVM patch. You've used "Java Script", "javascript" and "webkit" in various places.
Filip Pizlo
Comment 4 2013-10-23 13:46:53 PDT
OK, it looks like we have GetById IC's and OSR exits working with stackmap/patchpoint. So, as far as I can tell, those intrinsics Work As Advertised. So lets get 'em landed in LLVM trunk!
Filip Pizlo
Comment 5 2013-11-02 20:18:03 PDT
Created attachment 215844 [details] the patch
Filip Pizlo
Comment 6 2013-11-02 20:54:41 PDT
Created attachment 215845 [details] the patch
Geoffrey Garen
Comment 7 2013-11-03 10:18:19 PST
Comment on attachment 215845 [details] the patch r=me
Filip Pizlo
Comment 8 2013-11-03 10:22:56 PST
Landed in http://trac.webkit.org/changeset/158535
Note You need to log in before you can comment on or make changes to this bug.