Bug 122269

Summary: [WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122213    
Attachments:
Description Flags
Patch
none
Patch for landing
none
A better patch for landing. none

Zan Dobersek
Reported 2013-10-03 08:33:54 PDT
[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
Attachments
Patch (7.45 KB, patch)
2013-10-03 08:46 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.82 KB, patch)
2013-10-04 03:00 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
A better patch for landing. (7.82 KB, patch)
2013-10-04 03:04 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-10-03 08:46:30 PDT
Created attachment 213252 [details] Patch
Darin Adler
Comment 2 2013-10-03 12:46:10 PDT
Comment on attachment 213252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213252&action=review > Source/WebCore/xml/XMLHttpRequestProgressEvent.idl:29 > + OperationsNotDeletable No operations in this class, so it would be best if we did not add this.
Zan Dobersek
Comment 3 2013-10-04 03:00:59 PDT
Created attachment 213347 [details] Patch for landing Had to add the attribute to two more exception interfaces, will run through the EWS one more time.
Zan Dobersek
Comment 4 2013-10-04 03:04:42 PDT
Created attachment 213348 [details] A better patch for landing.
Zan Dobersek
Comment 5 2013-10-04 13:21:08 PDT
Comment on attachment 213348 [details] A better patch for landing. Clearing flags on attachment: 213348 Committed r156907: <http://trac.webkit.org/changeset/156907>
Zan Dobersek
Comment 6 2013-10-04 13:21:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.