Bug 122265

Summary: [CSS Regions] Follow-up code style change after bug #121828 All regions have layers
Product: WebKit Reporter: Mihai Maerean <mmaerean>
Component: WebCore Misc.Assignee: Mihai Maerean <mmaerean>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
patch none

Mihai Maerean
Reported 2013-10-03 05:39:37 PDT
Implement the changes requested in review at bug #121828 All regions have layers https://bugs.webkit.org/show_bug.cgi?id=121828#c14
Attachments
patch (4.17 KB, patch)
2013-10-03 06:33 PDT, Mihai Maerean 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihai Maerean
Comment 1 2013-10-03 06:33:44 PDT
Created attachment 213243 [details] patch
Darin Adler
Comment 2 2013-10-03 12:24:31 PDT
Comment on attachment 213243 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=213243&action=review > Source/WebCore/rendering/RenderMultiColumnSet.cpp:417 > + // RenderMultiColumnSet derives from RenderRegion, but unlike the CSS Regions specification, the Multi-Columns CSS > + // specification states that the column boxes do not establish new Stacking Contexts. Missing comma here after the word "but". I’ll set commit-queue+ anyway, because we should not hold this all up just for a comma.
WebKit Commit Bot
Comment 3 2013-10-03 12:51:50 PDT
Comment on attachment 213243 [details] patch Clearing flags on attachment: 213243 Committed r156850: <http://trac.webkit.org/changeset/156850>
WebKit Commit Bot
Comment 4 2013-10-03 12:51:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.