Bug 121875

Summary: Replace CSS3_TEXT build flag with Experimental feature settings
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: CSSAssignee: Kiet Ho <kiet.ho>
Status: RESOLVED FIXED    
Severity: Normal CC: 709922234, brunoabinader, commit-queue, dbates, dino, ebrahim, enrica, jonlee, kiet.ho, ntim, simon.fraser, stearns, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76173, 229084    
Attachments:
Description Flags
Patch
none
Patch beidson: review-

Myles C. Maxfield
Reported 2013-09-24 15:48:41 PDT
Enabling CSS3 Text on Mac
Attachments
Patch (58.59 KB, patch)
2013-09-24 15:52 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (58.63 KB, patch)
2013-09-25 10:32 PDT, Myles C. Maxfield 		beidson: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2013-09-24 15:52:28 PDT
Created attachment 212512 [details] Patch
Alexey Proskuryakov
Comment 2 2013-09-25 10:21:29 PDT
Comment on attachment 212512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212512&action=review > LayoutTests/platform/mac/TestExpectations:906 > # CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT). > -webkit.org/b/58491 fast/css3-text/css3-text-decoration > -webkit.org/b/76173 fast/css3-text/css3-text-align-last > -webkit.org/b/99945 fast/css3-text/css3-text-justify [ Failure ] > -webkit.org/b/112755 fast/css3-text/css3-text-indent [ Failure ImageOnlyFailure ] > +webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ] This comment doesn't appear to be true any more. What should it be saying?
Myles C. Maxfield
Comment 3 2013-09-25 10:30:08 PDT
Comment on attachment 212512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212512&action=review >> LayoutTests/platform/mac/TestExpectations:906 >> +webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ] > > This comment doesn't appear to be true any more. What should it be saying? Oops, I missed the comment. I'll upload a modified version
Myles C. Maxfield
Comment 4 2013-09-25 10:32:33 PDT
Created attachment 212596 [details] Patch
Tim Horton
Comment 5 2013-09-26 14:08:37 PDT
Comment on attachment 212596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212596&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Gotta fix this line. Remove it or explain why (I think there are no new tests because the tests already exist and you're turning them on? You should say that. > Tools/Scripts/webkitperl/FeatureList.pm:201 > + define => "ENABLE_CSS3_TEXT", default => (isAppleMacWebKit() || isEfl() || isGtk()), value => \$css3TextSupport }, Does it work on Windows/should we turn it on there too? Most webby features like this we try to keep in sync, I think. > LayoutTests/platform/mac/TestExpectations:905 > +webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ] Why? Does it just need new expectations?
Myles C. Maxfield
Comment 6 2013-09-30 14:24:48 PDT
Reopened because we want to do this
Brady Eidson
Comment 7 2016-05-24 22:07:18 PDT
Comment on attachment 212596 [details] Patch Assuming that patches for review since 2013 are stale, r-
Ebrahim Byagowi
Comment 8 2017-10-17 02:56:58 PDT
BUMP
Tim Nguyen (:ntim)
Comment 9 2022-05-19 07:17:25 PDT
I don't think we should have a build flag, some more tailored runtime settings would be much more preferable.
Kiet Ho
Comment 10 2022-05-24 16:11:42 PDT
Pull request: https://github.com/WebKit/WebKit/pull/993
EWS
Comment 11 2022-05-29 00:58:25 PDT
Committed r295010 (251105@main): <https://commits.webkit.org/251105@main> Reviewed commits have been landed. Closing PR #993 and removing active labels.
Radar WebKit Bug Importer
Comment 12 2022-05-29 00:59:13 PDT
<rdar://problem/94083925>
Note You need to log in before you can comment on or make changes to this bug.