Bug 121417

Summary: Buildfix for !ENABLE(CUSTOM_PROTOCOLS) platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, ap, beidson, cdumez, cmarcelo, commit-queue, darin, gyuyoung.kim, gyuyoung.kim, kbalazs, menard, ossy, philn, rakuco, skyul, webkit-ews, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110141    
Attachments:
Description Flags
Patch
none
alternative fix
none
alternative fix
none
alternative fix none

Csaba Osztrogonác
Reported 2013-09-16 03:05:31 PDT
SSIA
Attachments
Patch (2.24 KB, patch)
2013-09-16 03:09 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
alternative fix (2.74 KB, patch)
2013-09-16 03:36 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
alternative fix (4.18 KB, patch)
2013-09-16 03:58 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
alternative fix (5.06 KB, patch)
2013-09-16 04:13 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-09-16 03:09:13 PDT
Created attachment 211749 [details] Patch
Csaba Osztrogonác
Comment 2 2013-09-16 03:28:13 PDT
(In reply to comment #1) > Created an attachment (id=211749) [details] > Patch The previous discussion about it: https://bugs.webkit.org/show_bug.cgi?id=110141#c25 > There are 2 possible fix for it: > - including CustomProtocolManagerProxyMessages.h conditionally > - adding CustomProtocolManagerProxy.messages.in to the cmake build system to generate the useless CustomProtocolManagerProxyMessages.h
Csaba Osztrogonác
Comment 3 2013-09-16 03:36:37 PDT
Created attachment 211754 [details] alternative fix alternative fix, I haven't tested it yet
Early Warning System Bot
Comment 4 2013-09-16 03:43:11 PDT
Comment on attachment 211754 [details] alternative fix Attachment 211754 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1810205
Csaba Osztrogonác
Comment 5 2013-09-16 03:58:51 PDT
Created attachment 211758 [details] alternative fix with additional Qt and GTK buildfixes
Csaba Osztrogonác
Comment 6 2013-09-16 04:13:30 PDT
Created attachment 211760 [details] alternative fix with one more GTK buildfix
Csaba Osztrogonác
Comment 7 2013-09-16 04:33:29 PDT
Comment on attachment 211760 [details] alternative fix r? it too, and let the reviewer to decide which one is the better.
Csaba Osztrogonác
Comment 8 2013-09-16 06:13:42 PDT
Comment on attachment 211749 [details] Patch I prefer the alternative way. It is a little bit longer, but more general.
Csaba Osztrogonác
Comment 9 2013-09-17 12:59:05 PDT
Comment on attachment 211760 [details] alternative fix Clearing flags on attachment: 211760 Committed r155987: <http://trac.webkit.org/changeset/155987>
Csaba Osztrogonác
Comment 10 2013-09-17 12:59:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.