Bug 121058

Summary:

Remove HTMLTextFormControl::fixPlaceholderRenderer

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Forms

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, kling, koivisto, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

87155

Bug Blocks:

120685, 121073

Attachments:

Description	Flags
Cleanup	tkent: review+

Ryosuke Niwa

Reported 2013-09-09 16:31:15 PDT

Observe: -void HTMLTextFormControlElement::fixPlaceholderRenderer(HTMLElement* placeholder, HTMLElement* siblingElement) -{ - // FIXME: We should change the order of DOM nodes. But it makes an assertion - // failure in editing code. That's because the assertion is bogus.

Attachments
Cleanup (17.33 KB, patch) 2013-09-09 17:04 PDT, Ryosuke Niwa	tkent: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-09-09 17:04:27 PDT

Created attachment 211121 [details] Cleanup

Ryosuke Niwa

Comment 2 2013-09-09 17:08:49 PDT

I guess I should mention that this was inspired by https://chromium.googlesource.com/chromium/blink/+/2abaaaad08b1b5802da65a8797f4bec721eec952 but my patch is nothing like Blink's.

Kent Tamura

Comment 3 2013-09-09 17:22:21 PDT

(In reply to comment #2) > I guess I should mention that this was inspired by https://chromium.googlesource.com/chromium/blink/+/2abaaaad08b1b5802da65a8797f4bec721eec952 but my patch is nothing like Blink's. Your patch is the right fix, and it is different from the Blink change.

Kent Tamura

Comment 4 2013-09-09 17:23:24 PDT

Comment on attachment 211121 [details] Cleanup ok

Ryosuke Niwa

Comment 5 2013-09-09 18:07:42 PDT

Committed r155408: <http://trac.webkit.org/changeset/155408>

Note You need to log in before you can comment on or make changes to this bug.