Bug 120878

Summary: Split MediaStreamDescriptor.h and MediaStreamComponent.h into .h and .cpp
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebCore Misc.Assignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, gyuyoung.kim, hta, jer.noble, philn, rakuco, sergio, tommyw, xan.lopez
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 121101    
Attachments:
Description Flags
Proposed patch
none
Updated patch
none
Include new files in CMakeLists.txt none

Eric Carlson
Reported 2013-09-06 11:57:24 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/270b07c899154510d539c7e1d2e0411be46c257a What one were two simple classes have grown and now needs a split into a header and a implementation file. These files will go through some work soon as well.
Attachments
Proposed patch (24.06 KB, patch)
2013-09-10 13:20 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch (24.18 KB, patch)
2013-09-10 13:33 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Include new files in CMakeLists.txt (24.82 KB, patch)
2013-09-10 13:58 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-09-10 13:20:00 PDT
Created attachment 211231 [details] Proposed patch
WebKit Commit Bot
Comment 2 2013-09-10 13:22:00 PDT
Attachment 211231 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/LocalMediaStream.cpp', u'Source/WebCore/Modules/mediastream/MediaStream.cpp', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/mediastream/MediaStreamComponent.cpp', u'Source/WebCore/platform/mediastream/MediaStreamComponent.h', u'Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp', u'Source/WebCore/platform/mediastream/MediaStreamDescriptor.h']" exit_code: 1 Source/WebCore/platform/mediastream/MediaStreamDescriptor.h:62: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 3 2013-09-10 13:33:17 PDT
Created attachment 211232 [details] Updated patch
Sergio Correia (qrwteyrutiyoup)
Comment 4 2013-09-10 13:44:34 PDT
Maybe add MediaStreamComponent.cpp and MediaStreamDescriptor.cpp to Source/WebCore/CMakeLists as well?
Eric Carlson
Comment 5 2013-09-10 13:58:43 PDT
Created attachment 211238 [details] Include new files in CMakeLists.txt
Jer Noble
Comment 6 2013-09-10 14:01:48 PDT
Comment on attachment 211238 [details] Include new files in CMakeLists.txt LGTM. r=me.
WebKit Commit Bot
Comment 7 2013-09-10 14:41:00 PDT
Comment on attachment 211238 [details] Include new files in CMakeLists.txt Clearing flags on attachment: 211238 Committed r155477: <http://trac.webkit.org/changeset/155477>
WebKit Commit Bot
Comment 8 2013-09-10 14:41:03 PDT
All reviewed patches have been landed. Closing bug.
Sergio Correia (qrwteyrutiyoup)
Comment 9 2013-09-10 15:08:17 PDT
(In reply to comment #5) > Created an attachment (id=211238) [details] > Include new files in CMakeLists.txt The files were included in the CMakeList.txt with a wrong path, and caused build problems in EFL :) I submitted https://bugs.webkit.org/show_bug.cgi?id=121126 to fix it.
Eric Carlson
Comment 10 2013-09-11 09:13:07 PDT
(In reply to comment #9) > (In reply to comment #5) > > Created an attachment (id=211238) [details] [details] > > Include new files in CMakeLists.txt > > The files were included in the CMakeList.txt with a wrong path, and caused build problems in EFL :) > Sorry about that :-( > I submitted https://bugs.webkit.org/show_bug.cgi?id=121126 to fix it. > Thanks!
Note You need to log in before you can comment on or make changes to this bug.