Bug 120532

Summary: Fix SynchronousLoaderClient class for !USE(CFNETWORK) platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, danw, darin, gustavo, gyuyoung.kim, jberlin, mrobinson, ossy, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 120539    
Bug Blocks: 108832    
Attachments:
Description Flags
Patch
none
patch-for-ews
none
patch-for-ews
none
Patch none

Csaba Osztrogonác
Reported 2013-08-30 09:32:07 PDT
SynchronousLoaderClient::didReceiveAuthenticationChallengedidReceiveAuthenticationChallenge() is guarded by USE(CFNETWORK) in Source/WebCore/platform/network/SynchronousLoaderClient.cpp, but isn't in its header. It causes link failure on !CF platforms with enabled NetworkProcess. Guarding this function is safe, because it is implemented in the base class of SynchronousLoaderClient by ResourceHandleClient. (It is an empty function.)
Attachments
Patch (1.71 KB, patch)
2013-08-30 09:33 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch-for-ews (1.67 KB, patch)
2013-08-30 10:56 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch-for-ews (11.25 KB, patch)
2013-09-02 02:39 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (11.28 KB, patch)
2013-09-04 14:01 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-08-30 09:33:47 PDT
Created attachment 210121 [details] Patch
Darin Adler
Comment 2 2013-08-30 09:36:20 PDT
Comment on attachment 210121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210121&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Commit queue can’t handle a patch that has a line like this in it.
Csaba Osztrogonác
Comment 3 2013-08-30 09:45:08 PDT
Committed r154891: <http://trac.webkit.org/changeset/154891>
Jessie Berlin
Comment 4 2013-08-30 10:32:51 PDT
This broke the Mac build http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20%28Build%29/builds/15596/steps/compile-webkit/logs/stdio /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/platform/network/mac/SynchronousLoaderClient.mm:35:31: error: out-of-line definition of 'didReceiveAuthenticationChallenge' does not match any declaration in 'WebCore::SynchronousLoaderClient' void SynchronousLoaderClient::didReceiveAuthenticationChallenge(ResourceHandle*, const AuthenticationChallenge& challenge) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
WebKit Commit Bot
Comment 5 2013-08-30 10:38:25 PDT
Re-opened since this is blocked by bug 120539
Csaba Osztrogonác
Comment 6 2013-08-30 10:44:00 PDT
Sorry for the breakage, I rolled it out for now, will fix a little bit later.
Csaba Osztrogonác
Comment 7 2013-08-30 10:56:08 PDT
Created attachment 210133 [details] patch-for-ews patch for EWS
Csaba Osztrogonác
Comment 8 2013-09-02 02:28:44 PDT
*** Bug 120533 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 9 2013-09-02 02:39:39 PDT
Created attachment 210271 [details] patch-for-ews CFNETWORK implementation of SynchronousLoaderClient::didReceiveAuthenticationChallenge() and SynchronousLoaderClient::platformBadResponseError() shouldn't be in the cross-platform SynchronousLoaderClient.cpp, but in cf/SynchronousLoaderClientCFNet.cpp
Csaba Osztrogonác
Comment 10 2013-09-02 08:16:44 PDT
Comment on attachment 210271 [details] patch-for-ews EWS bots are happy, so r? for this patch.
Csaba Osztrogonác
Comment 11 2013-09-03 14:56:10 PDT
Ping
Darin Adler
Comment 12 2013-09-04 09:27:43 PDT
Comment on attachment 210271 [details] patch-for-ews View in context: https://bugs.webkit.org/attachment.cgi?id=210271&action=review > Source/WebCore/platform/network/cf/SynchronousLoaderClientCFNet.cpp:34 > +#if USE(CFNETWORK) > +#include <CFNetwork/CFURLConnectionPriv.h> > +#endif If this entire file is only for CFNetwork, then why the #if? If we do have an #if, it should wrap the whole file, not just the functions and this one include.
Csaba Osztrogonác
Comment 13 2013-09-04 14:01:47 PDT
Created attachment 210492 [details] Patch I used #if guards similar to other *CFNet.cpp. But you're right, guarding the whole file is reasonable, so I fixed it.
Csaba Osztrogonác
Comment 14 2013-09-05 02:50:26 PDT
Comment on attachment 210492 [details] Patch Clearing flags on attachment: 210492 Committed r155108: <http://trac.webkit.org/changeset/155108>
Csaba Osztrogonác
Comment 15 2013-09-05 02:50:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.