Bug 120413

Summary: [curl] Use utf8 for headers in CurlDownload.
Product: WebKit Reporter: Tamas Czene <tczene>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, commit-queue, galpeter, ossy, peavo
Priority: P2 Keywords: Curl
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
proposed patch none

Tamas Czene
Reported 2013-08-28 07:07:22 PDT
[curl] Use utf8 for headers in CurlDownload.
Attachments
proposed patch (1.28 KB, patch)
2013-08-28 07:10 PDT, Tamas Czene 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tamas Czene
Comment 1 2013-08-28 07:10:24 PDT
Created attachment 209881 [details] proposed patch
Anders Carlsson
Comment 2 2013-09-02 07:23:18 PDT
(In reply to comment #0) > [curl] Use utf8 for headers in CurlDownload. Why?
Peter Gal
Comment 3 2013-09-04 10:31:34 PDT
(In reply to comment #2) > (In reply to comment #0) > > [curl] Use utf8 for headers in CurlDownload. > > Why? I think because the header can contain utf8 characters, like for example the name of the file can be in utf8 (in the content-disposition header). There is also a testcase for this: http/tests/download/literal-utf-8.html.
Brent Fulgham
Comment 4 2013-09-12 11:04:58 PDT
Comment on attachment 209881 [details] proposed patch Seems find, and unlikely to hurt any other port. r=me.
WebKit Commit Bot
Comment 5 2013-09-12 11:28:27 PDT
Comment on attachment 209881 [details] proposed patch Clearing flags on attachment: 209881 Committed r155634: <http://trac.webkit.org/changeset/155634>
WebKit Commit Bot
Comment 6 2013-09-12 11:28:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.