Bug 120406

Summary: [GTK] [WK2] TestWebKitWebView page-visibility fails
Product: WebKit Reporter: Brian Holt <brian.holt>
Component: WebKitGTKAssignee: Brian Holt <brian.holt>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mario, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117689    
Attachments:
Description Flags
Patch none

Brian Holt
Reported 2013-08-28 06:17:43 PDT
The unit test for page-visibility fails because the return value from JS is not a string. ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp:366:char* jsValueToCString(JSGlobalContextRef, JSValueRef): assertion failed: (JSValueIsString(context, value))
Attachments
Patch (4.50 KB, patch)
2013-08-28 09:16 PDT, Brian Holt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Holt
Comment 1 2013-08-28 09:16:39 PDT
Created attachment 209895 [details] Patch
WebKit Commit Bot
Comment 2 2013-08-28 09:17:53 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Brian Holt
Comment 3 2013-08-28 09:19:18 PDT
It looks like this test was missed when the prefixes were removed in https://bugs.webkit.org/show_bug.cgi?id=102340. The proposed patch fixes this specific issue, but there are still others preventing TestWebKitWebView from running.
Gustavo Noronha (kov)
Comment 4 2013-08-29 10:07:10 PDT
Comment on attachment 209895 [details] Patch Thanks!
WebKit Commit Bot
Comment 5 2013-08-29 10:21:14 PDT
Comment on attachment 209895 [details] Patch Clearing flags on attachment: 209895 Committed r154818: <http://trac.webkit.org/changeset/154818>
WebKit Commit Bot
Comment 6 2013-08-29 10:21:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.