Bug 12021
| Summary: | prepare-ChangeLog doesn't report moved/copied files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ap, ggaren |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
David Kilzer (:ddkilzer)
The prepare-ChangeLog script uses 'svn diff' instead of 'svn stat' to get a list of changed files for a ChangeLog entry. The 'svn diff' command skips moved/copied files unless they've been changed after they were moved. The best way to fix this is to switch to using 'svn stat'.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
I think we had been using svn diff because svn stat was orders of magnitude slower. Not sure if that improved with the new svn, though.
David Kilzer (:ddkilzer)
(In reply to comment #1)
> I think we had been using svn diff because svn stat was orders of magnitude
> slower. Not sure if that improved with the new svn, though.
Yes, I made that change in r14814 (Bug 9395). However, r15025 (Bug 9570) let you specify a list of files and directories to operate on, which will greatly improve speed when running and helps if you're working on multiple patches in the same working copy.
David Kilzer (:ddkilzer)
(In reply to comment #1)
> I think we had been using svn diff because svn stat was orders of magnitude
> slower. Not sure if that improved with the new svn, though.
Which new svn? Was there a change on the server side, or a new svn client?
David Kilzer (:ddkilzer)
*** This bug has been marked as a duplicate of 10342 ***