Bug 119880

Summary: [Qt] Build fix (broken since r154142)
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[Qt] Trivial build fix
gyuyoung.kim: review+
[Qt] Build fix
gyuyoung.kim: review+
[Qt] Build fix (with description in ChangeLog) none

Julien Brianceau
Reported 2013-08-16 00:32:34 PDT
Our sh4 build bot is broken since r154142: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/28747 /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp: In member function 'void WebCore::XMLDocumentParser::parseStartElement()': /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:508:38: error: base operand of '->' has non-pointer type 'WebCore::FrameLoader' make[3]: *** [.obj/release-shared/xml/parser/XMLDocumentParserQt.o] Error 1
Attachments
[Qt] Trivial build fix (1.22 KB, patch)
2013-08-16 00:35 PDT, Julien Brianceau 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
[Qt] Build fix (1.24 KB, patch)
2013-08-16 01:06 PDT, Julien Brianceau 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
[Qt] Build fix (with description in ChangeLog) (1.32 KB, patch)
2013-08-16 01:20 PDT, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-08-16 00:35:29 PDT
Created attachment 208887 [details] [Qt] Trivial build fix
Julien Brianceau
Comment 2 2013-08-16 01:06:18 PDT
Created attachment 208889 [details] [Qt] Build fix
Julien Brianceau
Comment 3 2013-08-16 01:20:41 PDT
Created attachment 208892 [details] [Qt] Build fix (with description in ChangeLog)
WebKit Commit Bot
Comment 4 2013-08-16 01:34:41 PDT
The commit-queue encountered the following flaky tests while processing attachment 208887 [details]: http/tests/navigation/ping-cross-origin-from-https.html bug 51314 (authors: japhet@chromium.org and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2013-08-16 01:51:37 PDT
Comment on attachment 208892 [details] [Qt] Build fix (with description in ChangeLog) Clearing flags on attachment: 208892 Committed r154168: <http://trac.webkit.org/changeset/154168>
WebKit Commit Bot
Comment 6 2013-08-16 01:51:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.