Bug 11981
| Summary: | SVG Renderers must implement computeAbsoluteRepaintRect | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | hyatt, zimmermann |
| Priority: | P2 | Keywords: | SVGHitList |
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
Eric Seidel (no email)
computeAbsoluteRepaintRect needs a new name
I'm still not sure I entirely understand computeAbsoluteRepaintRect. But given this comment in RenderObject.h:
// Given a rect in the object's coordinate space, this method converts the rectangle to the view's
// coordinate space.
virtual void computeAbsoluteRepaintRect(IntRect&, bool fixed = false);
It seems the function needs a new name. It really has nothing to do with repaint rects it seems.
I think pretty much all of the SVG code is either missing that function, or has a bogus implementation thereof. It would be nice to clarify the idea behind that function, and make all versions of getAbsoluteRepaintRect() use it if appropriate.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Well, I've come to understand what this function does. :) And it's very important. All of the SVG renderers need to implement this so that we can finally get incremental text repaints to work properly, as well as have a prayer of getting getOverflowClippedRect() to return a properly clipped repaint rect.
Eric Seidel (no email)
*** This bug has been marked as a duplicate of 23881 ***