Bug 119632

Summary: [CSS Grid Layout] Resolve named grid lines
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan, svillar, syoichi
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 119540    
Bug Blocks: 103310    
Attachments:
Description Flags
Patch none

Sergio Villar Senin
Reported 2013-08-09 08:27:27 PDT
The patch for bug 119540 will add parsing support for named grid lines. That's the first step, after that we need to use that information to properly position the different elements in the grid. This was done in Blink in: r152659 Properly resolve named grid lines This change adds the code to convert from a raw named grid line (stored in RenderStyle) to its actual grid position. and r153794 [CSS Grid Layout] Support named grid lines with 'span' This change implements the resolution for named grid lines with 'span', which is the missing piece to fully support named grid lines.
Attachments
Patch (25.86 KB, patch)
2013-09-04 09:40 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-09-04 09:40:27 PDT
Created attachment 210471 [details] Patch
Sergio Villar Senin
Comment 2 2013-09-06 01:03:37 PDT
Comment on attachment 210471 [details] Patch Clearing flags on attachment: 210471 Committed r155181: <http://trac.webkit.org/changeset/155181>
Sergio Villar Senin
Comment 3 2013-09-06 01:03:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.