Bug 119622

Summary:

[CSS Regions] Not possible to clear the selection when mixing content from different FlowThreads

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, hyatt, jfernandez, kondapallykalyan, mibalan, rniwa, WebkitBugTracker, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

106817, 109283

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Javier Fernandez

Reported 2013-08-09 05:15:59 PDT

This bug was hidden by the fix for the bug 105641, which basically prevented the selection to be rendered when crossing the FlowThread boundaries. Such fix is not correct, because instead of fixing the actual bug it adds restrictions on how the selection works with Regions. We need to properly fix the selection clearing operation, allowing selections to cross RenderFlow boundaries and select content from different Regions.

Attachments
Patch (5.08 KB, patch) 2013-08-09 06:10 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (5.08 KB, patch) 2013-08-09 06:34 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (5.77 KB, patch) 2013-08-09 12:07 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Patch (10.17 KB, patch) 2013-08-14 15:30 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2013-08-09 06:10:21 PDT

Created attachment 208425 [details] Patch

Build Bot

Comment 2 2013-08-09 06:13:30 PDT

Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1353447

Build Bot

Comment 3 2013-08-09 06:14:33 PDT

Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1405199

EFL EWS Bot

Comment 4 2013-08-09 06:15:04 PDT

Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1411318

Early Warning System Bot

Comment 5 2013-08-09 06:15:55 PDT

Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1369686

Early Warning System Bot

Comment 6 2013-08-09 06:16:04 PDT

Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1414328

EFL EWS Bot

Comment 7 2013-08-09 06:16:12 PDT

Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1369685

Javier Fernandez

Comment 8 2013-08-09 06:34:42 PDT

Created attachment 208429 [details] Patch

Build Bot

Comment 9 2013-08-09 06:38:30 PDT

Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1385270

Build Bot

Comment 10 2013-08-09 06:41:31 PDT

Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1369695

Sergio Villar Senin

Comment 11 2013-08-09 07:31:50 PDT

Comment on attachment 208429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208429&action=review Not really my field of expertise, just doing an informal general review. > Source/WebCore/rendering/RenderView.cpp:782 > + bool cond = os && os != stop; Do not use "cond", use a more descriptive name. > Source/WebCore/rendering/RenderView.cpp:849 > + cond = o && o != stop; Ditto. > Source/WebCore/rendering/RenderView.cpp:873 > + } The code looks exactly the same than the above, would it be possible to refactor it in some function?

EFL EWS Bot

Comment 12 2013-08-09 08:00:24 PDT

Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1353465

EFL EWS Bot

Comment 13 2013-08-09 08:28:31 PDT

Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1414369

Early Warning System Bot

Comment 14 2013-08-09 08:41:43 PDT

Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1399219

Early Warning System Bot

Comment 15 2013-08-09 08:42:53 PDT

Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1350447