Bug 119447

Summary: REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, gergely, ggaren, kilvadyb, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108664    
Attachments:
Description Flags
ctiVMThrowTrampolineSlowpath fix for mips architecture. none

Julien Brianceau
Reported 2013-08-02 09:29:47 PDT
Crashes are observed during javascriptcore tests. For instance, array-defineOwnProperty.js: This test checks the behavior of [[DefineOwnProperty]] applied to Array objects (see ES5.1 15.4.5.1). On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". PASS Object.defineProperty([], 'x', { get:function(){return true;} }).x is true PASS Object.defineProperty([], 'length', { value: 1 }).length is 1 PASS var a = Object.defineProperty([], 'length', { writable: false }); a[1] = 1; a.length is 0 PASS var a = Object.defineProperty([], 'length', { writable: false }); a.length = 1; a.length is 0 PASS var a = Object.defineProperty([], 'length', {}); a.length = 1; a.length is 1 Segmentation fault
Attachments
ctiVMThrowTrampolineSlowpath fix for mips architecture. (2.16 KB, patch)
2013-08-02 09:36 PDT, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-08-02 09:36:19 PDT
Created attachment 208028 [details] ctiVMThrowTrampolineSlowpath fix for mips architecture. This patches fixes the issue on my Broadcom 7241 board.
Geoffrey Garen
Comment 2 2013-08-02 11:21:29 PDT
Comment on attachment 208028 [details] ctiVMThrowTrampolineSlowpath fix for mips architecture. r=me
WebKit Commit Bot
Comment 3 2013-08-02 11:44:11 PDT
Comment on attachment 208028 [details] ctiVMThrowTrampolineSlowpath fix for mips architecture. Clearing flags on attachment: 208028 Committed r153659: <http://trac.webkit.org/changeset/153659>
WebKit Commit Bot
Comment 4 2013-08-02 11:44:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.