Bug 11943

Summary: Quirksmode: Break Tag Extra Space Bug
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Layout and RenderingAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan, mitz, rniwa, robert, webkit
Priority: P2 Keywords: HasReduction
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.quirksmode.org/bugreports/archives/2006/10/Break_Tag_Extra_Space_Bug.html
Bug Depends on:    
Bug Blocks: 9610    
Attachments:
Description Flags
Test page
none
Patch
none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
none
Patch
none
Patch none

David Kilzer (:ddkilzer)
Reported 2006-12-23 04:40:00 PST
A break tag in your code when text is aligned right causes a space at the end of the line. This has the effect that the last line in a group appears too far right. Reported on 5 October 2006. Test page: http://www.designdetector.com/bugs/break-tag-extra-space-bug.html Tested on locally-built debug build of WebKit r18399 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037).
Attachments
Test page (1.92 KB, text/html)
2006-12-23 04:42 PST, David Kilzer (:ddkilzer) 		no flags
Details
Patch (5.70 KB, patch)
2013-07-25 11:55 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (723.66 KB, application/zip)
2013-07-27 16:56 PDT, Build Bot 		no flags
Details
Patch (6.01 KB, patch)
2013-09-17 11:20 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Patch (6.03 KB, patch)
2013-09-17 14:46 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-12-23 04:42:00 PST
Created attachment 11981 [details] Test page
Robert Blaut
Comment 2 2008-02-10 14:44:25 PST
Confirmed in the latest Webkit r30123
David Kilzer (:ddkilzer)
Comment 3 2008-04-14 22:45:15 PDT
No change in behavior with (tested with WebKit nightly build r31893): <http://trac.webkit.org/projects/webkit/changeset/31734>
Robert Hogan
Comment 4 2013-07-25 11:55:49 PDT
Created attachment 207473 [details] Patch
Build Bot
Comment 5 2013-07-27 16:56:08 PDT
Comment on attachment 207473 [details] Patch Attachment 207473 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1243608 New failing tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html editing/selection/leak-document-with-selection-inside.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html
Build Bot
Comment 6 2013-07-27 16:56:10 PDT
Created attachment 207592 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Dave Hyatt
Comment 7 2013-09-04 13:00:12 PDT
Comment on attachment 207473 [details] Patch r=me, but we know that what we really want to do is strip this trailing space out always. Let's file a follow-up bug to do just that and let's put FIXMEs in the code that indicate the right-alignment hack is temporary.
Robert Hogan
Comment 8 2013-09-17 11:20:34 PDT
Created attachment 211927 [details] Patch
WebKit Commit Bot
Comment 9 2013-09-17 14:21:59 PDT
Comment on attachment 211927 [details] Patch Rejecting attachment 211927 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 211927, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1825105
Robert Hogan
Comment 10 2013-09-17 14:46:46 PDT
Created attachment 211947 [details] Patch
Antti Koivisto
Comment 11 2013-09-18 10:24:08 PDT
So much FIXME and commentary.
WebKit Commit Bot
Comment 12 2013-09-18 10:57:22 PDT
Comment on attachment 211947 [details] Patch Clearing flags on attachment: 211947 Committed r156053: <http://trac.webkit.org/changeset/156053>
WebKit Commit Bot
Comment 13 2013-09-18 10:57:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.