Bug 118647

Summary: fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch
none
the patch
none
the patch
none
the patch
none
added more things
none
the patch ggaren: review+

Filip Pizlo
Reported 2013-07-13 09:39:06 PDT
I've now had two versions of these to play with. I think it would be better if it was checked in
Attachments
the patch (11.00 KB, patch)
2013-07-13 09:40 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (10.97 KB, patch)
2013-07-13 09:45 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (10.96 KB, patch)
2013-07-13 09:46 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (10.97 KB, patch)
2013-07-13 09:53 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
added more things (14.22 KB, patch)
2013-07-13 11:11 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (15.40 KB, patch)
2013-07-13 12:21 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-07-13 09:40:22 PDT
Created attachment 206609 [details] the patch
WebKit Commit Bot
Comment 2 2013-07-13 09:43:26 PDT
Attachment 206609 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:35: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:40: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:51: Declaration has space between * and variable name in uint8_t* start [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:59: Declaration has space between * and variable name in void* opaqueState [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:63: Declaration has space between * and variable name in uint8_t* start [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/ReducedFTL/ReducedFTL.c:65: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/ReducedFTL/ReducedFTL.c:81: Declaration has space between * and variable name in void* opaqueState [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:97: Declaration has space between * and variable name in void* opaque [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:119: Place brace on its own line for function definitions. [whitespace/braces] [4] Tools/ReducedFTL/ReducedFTL.c:127: Declaration has space between * and variable name in char* error [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:166: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/ReducedFTL/ReducedFTL.c:238: Declaration has space between * and variable name in uint8_t* pc [whitespace/declaration] [3] Tools/ReducedFTL/ReducedFTL.c:239: Declaration has space between * and variable name in uint8_t* end [whitespace/declaration] [3] Total errors found: 14 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2013-07-13 09:45:49 PDT
Created attachment 206610 [details] the patch Fix style, hopefully.
Filip Pizlo
Comment 4 2013-07-13 09:46:38 PDT
Created attachment 206611 [details] the patch Ugh, I keep forgetting proper C style etiquette.
WebKit Commit Bot
Comment 5 2013-07-13 09:52:23 PDT
Attachment 206611 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:42: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:122: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2013-07-13 09:53:49 PDT
Created attachment 206612 [details] the patch
WebKit Commit Bot
Comment 7 2013-07-13 09:55:11 PDT
Attachment 206612 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 8 2013-07-13 11:11:52 PDT
Created attachment 206616 [details] added more things
WebKit Commit Bot
Comment 9 2013-07-13 11:13:46 PDT
Attachment 206616 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:45: Alphabetical sorting problem. [build/include_order] [4] Tools/ReducedFTL/ReducedFTL.c:152: Declaration has space between * and variable name in LLVMModuleRef* modules [whitespace/declaration] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 10 2013-07-13 12:21:40 PDT
Created attachment 206618 [details] the patch Added options to experiment with contexts.
WebKit Commit Bot
Comment 11 2013-07-13 12:24:26 PDT
Attachment 206618 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/ReducedFTL/ReducedFTL.c', u'Tools/ReducedFTL/build.sh']" exit_code: 1 Tools/ReducedFTL/ReducedFTL.c:45: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 12 2013-07-15 19:27:05 PDT
Comment on attachment 206618 [details] the patch rs=me
Filip Pizlo
Comment 13 2013-07-16 13:36:30 PDT
Landed in http://trac.webkit.org/changeset/152738
Note You need to log in before you can comment on or make changes to this bug.