Bug 118265

Summary: [GTK][ThreadedCompositor] Add support for threaded compositor
Product: WebKit Reporter: Gwang Yoon Hwang <yoon>
Component: Layout and RenderingAssignee: Gwang Yoon Hwang <yoon>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, changseok, commit-queue, jaepark, mrobinson, noam, sergio, skyul, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 117227, 118383    
Bug Blocks: 100341    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Gwang Yoon Hwang
Reported 2013-07-01 15:33:10 PDT
By implementing ThreadedCoordinatedLayerTreeHost, this patch supports threaded compositor for WK2. In this initial implementation, threaded compositor only supports fixedLayout. COORDINATED_GRAPHICS_IPC is introduced to classify IPC specific codes from Coordinated Graphics. Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp : Calls XInitThreads to use thread-safe xlib. No new tests, this is an experimental feature.
Attachments
Patch (44.51 KB, patch)
2013-07-01 16:10 PDT, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Patch (44.41 KB, patch)
2013-07-04 05:05 PDT, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Patch (55.63 KB, patch)
2014-12-15 04:17 PST, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Patch (55.87 KB, patch)
2015-01-06 06:58 PST, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Patch (55.94 KB, patch)
2015-01-06 09:05 PST, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Patch (55.90 KB, patch)
2015-01-06 09:14 PST, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Patch (55.86 KB, patch)
2015-01-06 20:07 PST, Gwang Yoon Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Gwang Yoon Hwang
Comment 1 2013-07-01 16:10:03 PDT
Created attachment 205842 [details] Patch
Gwang Yoon Hwang
Comment 2 2013-07-04 05:05:50 PDT
Created attachment 206079 [details] Patch
Gwang Yoon Hwang
Comment 3 2014-12-15 04:17:34 PST
Created attachment 243287 [details] Patch
Gwang Yoon Hwang
Comment 4 2015-01-06 06:58:13 PST
Created attachment 244059 [details] Patch
Gwang Yoon Hwang
Comment 5 2015-01-06 09:05:08 PST
Created attachment 244065 [details] Patch
Gwang Yoon Hwang
Comment 6 2015-01-06 09:14:50 PST
Created attachment 244066 [details] Patch
Gwang Yoon Hwang
Comment 7 2015-01-06 09:17:02 PST
(In reply to comment #6) > Created attachment 244066 [details] > Patch Sorry for noise. I made a little typo in previous patch. Changes: * Change COORDINATED_GRAPHICS_IPC to COORDINATED_GRAPHICS_MULITIPROCESS * Rebase for current HEAD
Martin Robinson
Comment 8 2015-01-06 11:39:18 PST
Comment on attachment 244066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244066&action=review Looks good to me, thought the changes to platform independent files will need to be approved by Apple. > Source/WebKit2/ChangeLog:8 > + This patch introduces the Threaded Compositor for WebKitGTK+. Nit: the Threaded Compositor -> a threaded compositor > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:527 > +#if USE(COORDINATED_GRAPHICS_MULTIPROCESS) > m_page->send(Messages::WebPageProxy::DidChangeContentSize(size)); > #endif > +#endif These blocks do not have to be nested. I think it's clearer to not nest them actually. > Source/cmake/WebKitFeatures.cmake:152 > + WEBKIT_OPTION_DEFINE(ENABLE_THREADED_COMPOSITOR "Toggle Toggle Threaded Compositor support" OFF) Nit: Threaded Compositor -> threaded compositor > Tools/Scripts/webkitperl/FeatureList.pm:386 > + { option => "threaded-compositor", desc => "Toggle Threaded Compositor support", Ditto.
Gwang Yoon Hwang
Comment 9 2015-01-06 20:07:00 PST
Created attachment 244129 [details] Patch
Gwang Yoon Hwang
Comment 10 2015-01-06 20:14:23 PST
(In reply to comment #8) > Comment on attachment 244066 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244066&action=review > > Looks good to me, thought the changes to platform independent files will > need to be approved by Apple. > Okay, I'll ask for approval later. > > Source/WebKit2/ChangeLog:8 > > + This patch introduces the Threaded Compositor for WebKitGTK+. > > Nit: the Threaded Compositor -> a threaded compositor > > > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:527 > > +#if USE(COORDINATED_GRAPHICS_MULTIPROCESS) > > m_page->send(Messages::WebPageProxy::DidChangeContentSize(size)); > > #endif > > +#endif > > These blocks do not have to be nested. I think it's clearer to not nest them > actually. > Good point. Modified. > > Source/cmake/WebKitFeatures.cmake:152 > > + WEBKIT_OPTION_DEFINE(ENABLE_THREADED_COMPOSITOR "Toggle Toggle Threaded Compositor support" OFF) > > Nit: Threaded Compositor -> threaded compositor > Fixed. :) > > Tools/Scripts/webkitperl/FeatureList.pm:386 > > + { option => "threaded-compositor", desc => "Toggle Threaded Compositor support", > > Ditto. Fixed.
Anders Carlsson
Comment 11 2015-01-07 12:39:16 PST
Comment on attachment 244066 [details] Patch Cross platform files look fine to me.
WebKit Commit Bot
Comment 12 2015-01-07 20:29:25 PST
Comment on attachment 244129 [details] Patch Clearing flags on attachment: 244129 Committed r178095: <http://trac.webkit.org/changeset/178095>
WebKit Commit Bot
Comment 13 2015-01-07 20:29:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.