Bug 118085

Summary: [CSS Shapes] New positioning model: support for polygon shape-outside
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css-shapes/#relation-to-box-model-and-float-behavior
Bug Depends on:    
Bug Blocks: 117898    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
none
Patch
none
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion none

Bem Jones-Bey
Reported 2013-06-26 14:40:58 PDT
Add support for polygons in new model.
Attachments
Patch (27.31 KB, patch)
2013-07-25 09:57 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (685.51 KB, application/zip)
2013-07-25 12:20 PDT, Build Bot 		no flags
Details
Patch (27.28 KB, patch)
2013-07-26 09:21 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (535.45 KB, application/zip)
2013-07-26 11:18 PDT, WebKit Commit Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-07-25 09:57:24 PDT
Created attachment 207465 [details] Patch Tests for polygons
Dirk Schulze
Comment 2 2013-07-25 10:52:15 PDT
Comment on attachment 207465 [details] Patch rs=me
WebKit Commit Bot
Comment 3 2013-07-25 11:37:19 PDT
Comment on attachment 207465 [details] Patch Rejecting attachment 207465 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 207465, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 153334 = a745e206eb79eb857257745596d9f37c5f816c76 r153335 = c4956b111b263aad206d25462b4701403d8696ac r153336 = 6fded78ff136260a348a9a2e0734e5eb425573e2 r153337 = e9ad442dc6821b628008bcd50d8e27731a067653 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/1209320
Build Bot
Comment 4 2013-07-25 12:20:34 PDT
Comment on attachment 207465 [details] Patch Attachment 207465 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1207331 New failing tests: svg/batik/masking/maskRegions.svg
Build Bot
Comment 5 2013-07-25 12:20:35 PDT
Created attachment 207476 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Bem Jones-Bey
Comment 6 2013-07-26 09:21:39 PDT
Created attachment 207533 [details] Patch rebase
Max Vujovic
Comment 7 2013-07-26 09:28:04 PDT
Comment on attachment 207533 [details] Patch Setting cq+ per Bem's request.
WebKit Commit Bot
Comment 8 2013-07-26 11:18:48 PDT
Comment on attachment 207533 [details] Patch Rejecting attachment 207533 [details] from commit-queue. New failing tests: editing/selection/leak-document-with-selection-inside.html compositing/overflow/overflow-compositing-descendant.html Full output: http://webkit-queues.appspot.com/results/1251285
WebKit Commit Bot
Comment 9 2013-07-26 11:18:50 PDT
Created attachment 207541 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Bem Jones-Bey
Comment 10 2013-07-26 13:39:43 PDT
Comment on attachment 207533 [details] Patch Lets try this again. There's no way that this patch can cause any other tests to fail, so assuming it's a transient flake issue.
WebKit Commit Bot
Comment 11 2013-07-26 15:59:12 PDT
Comment on attachment 207533 [details] Patch Clearing flags on attachment: 207533 Committed r153386: <http://trac.webkit.org/changeset/153386>
WebKit Commit Bot
Comment 12 2013-07-26 15:59:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.