Bug 117302

Summary: [curl] Custom HTTP method support
Product: WebKit Reporter: Peter Gal <galpeter>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ossy
Priority: P2 Keywords: Curl
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
proposed patch none

Peter Gal
Reported 2013-06-06 08:41:15 PDT
The curl backend does not support custom http methods. For example one can not issue an XMLHTTPRequest with a method "MYMETHOD", the backend will issue instead a simple "GET" request.
Attachments
proposed patch (2.01 KB, patch)
2013-06-06 09:22 PDT, Peter Gal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Gal
Comment 1 2013-06-06 09:22:38 PDT
Created attachment 203941 [details] proposed patch
Kenneth Rohde Christiansen
Comment 2 2013-06-08 04:15:32 PDT
Comment on attachment 203941 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=203941&action=review > Source/WebCore/ChangeLog:10 > + > + No new tests, already covered by existing ones like: > + http/tests/xmlhttprequest/workers/methods.html > + http/tests/xmlhttprequest/workers/methods-async.html you dont need to update the result then?
Peter Gal
Comment 3 2013-06-08 04:31:15 PDT
(In reply to comment #2) > (From update of attachment 203941 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203941&action=review > > > Source/WebCore/ChangeLog:10 > > + > > + No new tests, already covered by existing ones like: > > + http/tests/xmlhttprequest/workers/methods.html > > + http/tests/xmlhttprequest/workers/methods-async.html > > you dont need to update the result then? No, because the results are OK. The tests were failing before.
Csaba Osztrogonác
Comment 4 2013-06-11 09:37:29 PDT
Comment on attachment 203941 [details] proposed patch Clearing flags on attachment: 203941 Committed r151441: <http://trac.webkit.org/changeset/151441>
Csaba Osztrogonác
Comment 5 2013-06-11 09:37:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.