Bug 117070

Summary: [Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: Tools / TestsAssignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED INVALID    
Severity: Normal CC: allan.jensen, eustas, jturcotte, kadam, rniwa
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110742    
Bug Blocks: 42194, 79668    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Zoltan Arvai
Reported 2013-05-31 06:12:54 PDT
crash log for WebProcess (pid <unknown>): STDOUT: <empty> STDERR: Received an invalid message "WebContextLegacyMessage.PostSynchronousMessage" from the web process. http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r151013%20%2835908%29/results.html backtrace https://gist.github.com/azbesthu/5684836
Attachments
Patch (1.51 KB, patch)
2013-05-31 06:51 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2013-05-31 06:53 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (2.68 KB, patch)
2013-06-03 22:01 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-05-31 06:38:09 PDT
posting messages in WK2 test causes crash. I'll add TextExpectation.
Ádám Kallai
Comment 2 2013-05-31 06:41:31 PDT
It have been landed in http://trac.webkit.org/changeset/151014. :)
Eugene Klyuchnikov
Comment 3 2013-05-31 06:51:08 PDT
Created attachment 203440 [details] Patch
Eugene Klyuchnikov
Comment 4 2013-05-31 06:53:55 PDT
Created attachment 203442 [details] Patch
Eugene Klyuchnikov
Comment 5 2013-05-31 06:56:24 PDT
Well, I've moved expectation, because there is a meta-bug that is responsible for the whole a group of tests that fail on WK2.
Zoltan Arvai
Comment 6 2013-05-31 07:03:45 PDT
(In reply to comment #5) > Well, I've moved expectation, because there is a meta-bug that is responsible > for the whole a group of tests that fail on WK2. Yes, that sounds reasonable. Probably the change can be landed without review like most of the unreviewed gardening patches.
Eugene Klyuchnikov
Comment 7 2013-05-31 08:22:05 PDT
Committed r151015: <http://trac.webkit.org/changeset/151015>
Ryosuke Niwa
Comment 8 2013-05-31 09:29:08 PDT
But why is this causing a crash?
Eugene Klyuchnikov
Comment 9 2013-06-02 23:39:26 PDT
In new test we use "eventSender.keyDown". As it is said in https://bugs.webkit.org/show_bug.cgi?id=42194 : "WebKitTestRunner needs an implementation of eventSender. Many tests fail because of this (hundreds)." What I see in stack trace: in WebPageProxy::didReceiveEvent in case of synchronous (test) keyboard event handling we face that type of first message in keyboard event queue is not the same as type of event we just appended to this queue. Assertion that type of last message in queue is the same as first message in queue means that we expect that queue is never longer that 1 item (at least for synchronous case). Stack trace has depth of 206 frames; there are 6 nested key events. 5 events are at "WebPageProxy.cpp:1395", invoked from handleKeyPressEvent. 6-th is at "WebPageProxy.cpp:1396", invoked from handleKeyReleaseEvent. So, when test reaches exit condition and begins unrolling, the problem occurs. I'm not sure, is it OK or NOK to nest eventSender.keyDown invocations. I'll prepare asynchronous test to see if will make Qt5-WK bot happy. (In reply to comment #8) > But why is this causing a crash?
Eugene Klyuchnikov
Comment 10 2013-06-03 22:01:00 PDT
Created attachment 203650 [details] Patch
Jocelyn Turcotte
Comment 11 2014-02-03 03:25:57 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.