Bug 116947
| Summary: | [Exclusions] Correct some problems that disabling subpixel layout exposed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bjonesbe, dino, giles_joplin, mihnea, simon.fraser, zalan |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Merge https://chromium.googlesource.com/chromium/blink/+/84540f0de96206eb3a4be98fec1cb3bd7d19ec4e
First round of changes to correct exclusion tests that started failing when subpixel layout was turned off, and to correct some problems that disabling subpixel layout exposed.
This set of changes just corrects four tests. It also revises the subpixel-utils code to bring it into line with the most recent LayoutUnit et al changes and to simplify its use a little. The ExclusionPolygon appendArc() method was corrected, so that the 3rd of 5 additional vertices is in the center of the arc. The firstIncludedIntervalLogicalTop() methods now use ceiledLayoutUnit() to convert a float to a LayoutUnit within the shape.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Bem Jones-Bey
That patch was a merge to blink of the WebKit bug 115455.
However, I'll let Hans say if this is a dup or if there were any changes on the blink side that need to be merged back.
Ryosuke Niwa
*** This bug has been marked as a duplicate of bug 115455 ***