Bug 116612

Summary: [Qt][Mips] r150484 broke the build
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: New BugsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, andersca, gergely, jturcotte, kadam, kilvadyb, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108664, 116578    
Attachments:
Description Flags
Patch none

Zoltan Arvai
Reported 2013-05-22 06:45:18 PDT
After the patch something went wrong on Qt Mips: /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp: In member function 'WebKit::PluginProcessProxy* WebKit::PluginProcessManager::getOrCreatePluginProcess(uint64_t)': /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:126: error: cannot convert 'std::nullptr_t' to 'WebKit::PluginProcessProxy*' in return make[3]: *** [.obj/release-shared/UIProcess/Plugins/PluginProcessManager.o] Error 1 changes in that file: http://trac.webkit.org/changeset/150484/trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp
Attachments
Patch (1.30 KB, patch)
2013-05-27 04:31 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-05-23 09:19:19 PDT
It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in Source/WTF/wtf/Compiler.h , because you use too old compiler. But now c++11 is mandatory for WebKit2, so you probably need newer compiler.
Balazs Kilvady
Comment 2 2013-05-23 10:19:46 PDT
(In reply to comment #1) > It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in > Source/WTF/wtf/Compiler.h , because you use too old compiler. > > But now c++11 is mandatory for WebKit2, so you probably need newer compiler. Tamk you for the info. We are working on it.
Balazs Kilvady
Comment 3 2013-05-23 10:21:02 PDT
(In reply to comment #2) > (In reply to comment #1) > > It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in > > Source/WTF/wtf/Compiler.h , because you use too old compiler. > > > > But now c++11 is mandatory for WebKit2, so you probably need newer compiler. > > Tamk you for the info. We are working on it. Sorry, I wanted to write: Thank you
Allan Sandfeld Jensen
Comment 4 2013-05-27 04:26:56 PDT
The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work.
Csaba Osztrogonác
Comment 5 2013-05-27 04:29:31 PDT
(In reply to comment #4) > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work. C++11 in WebKit2 is mandatory now... ... but feel free to find a WebKit2 owner for this fix. :)
Allan Sandfeld Jensen
Comment 6 2013-05-27 04:31:01 PDT
Created attachment 202969 [details] Patch
Allan Sandfeld Jensen
Comment 7 2013-05-27 04:32:46 PDT
(In reply to comment #5) > (In reply to comment #4) > > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work. > > C++11 in WebKit2 is mandatory now... > > ... but feel free to find a WebKit2 owner for this fix. :) All of C++11 is hardly mandatory, or we would depend on unreleased compilers. There is has to be an expected subset of featuers.
Anders Carlsson
Comment 8 2013-05-27 13:26:32 PDT
(In reply to comment #7) > (In reply to comment #5) > > (In reply to comment #4) > > > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work. > > > > C++11 in WebKit2 is mandatory now... > > > > ... but feel free to find a WebKit2 owner for this fix. :) > > All of C++11 is hardly mandatory, or we would depend on unreleased compilers. There is has to be an expected subset of featuers. I’ve generally only used features that’s available on compilers that have been out for at least two years. That includes MSVC 2010 as well as GCC 4.6.
Zoltan Arvai
Comment 9 2013-05-30 07:37:27 PDT
The bot is green again :)
Anders Carlsson
Comment 10 2013-05-30 12:15:39 PDT
Comment on attachment 202969 [details] Patch Clearing review flag.
Note You need to log in before you can comment on or make changes to this bug.