Bug 116310

Summary: [CSSRegions] Constrain auto-height region computation in a different way
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, commit-queue, esprehn+autocc, glenn, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2013-05-17 06:30:26 PDT
After https://bugs.webkit.org/show_bug.cgi?id=74132, the region is a render block. We can use RenderBox::constrainContentBoxLogicalHeightByMinMax instead of RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight.
Attachments
Patch (2.19 KB, patch)
2013-05-17 06:37 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.36 KB, patch)
2013-05-21 00:26 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2013-05-17 06:37:33 PDT
Created attachment 202077 [details] Patch
Alexandru Chiculita
Comment 2 2013-05-17 09:05:27 PDT
Comment on attachment 202077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review Looks good. Please, add a separate bug to track the other issue. > Source/WebCore/ChangeLog:10 > + Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children. We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height.
Mihnea Ovidenie
Comment 3 2013-05-21 00:10:34 PDT
(In reply to comment #2) > (From update of attachment 202077 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review > > Looks good. Please, add a separate bug to track the other issue. > > > Source/WebCore/ChangeLog:10 > > + Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children. > > We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height. Added bug: https://bugs.webkit.org/show_bug.cgi?id=116518 to track this issue.
Mihnea Ovidenie
Comment 4 2013-05-21 00:26:57 PDT
Created attachment 202387 [details] Patch for landing
WebKit Commit Bot
Comment 5 2013-05-21 01:00:34 PDT
The commit-queue encountered the following flaky tests while processing attachment 202387 [details]: media/track/track-remove-crash.html bug 115892 (author: eric.carlson@apple.com) svg/batik/text/textFeatures.svg bug 116326 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textLength.svg bug 116329 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textEffect3.svg bug 116521 (authors: darin@apple.com and zimmermann@kde.org) compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) editing/inserting/typing-at-end-of-line.html bug 116486 (author: enrica@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2013-05-21 01:01:56 PDT
Comment on attachment 202387 [details] Patch for landing Clearing flags on attachment: 202387 Committed r150427: <http://trac.webkit.org/changeset/150427>
WebKit Commit Bot
Comment 7 2013-05-21 01:01:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.