Bug 116115

Summary: [CSS Exclusions] Some layout tests fail to account for inline pixel snapping
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115292    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2013-05-14 12:09:31 PDT
Inline layout snaps boxes' logical top and bottom to pixels and line segment layout rounds the logical left and floors the logical right of segments. The following exclusions tests did not take this into account: shape-inside/shape-inside-polygon-layout.html shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html shape-outside-floats/shape-outside-floats-ellipse-margin-left.html shape-outside-floats/shape-outside-floats-ellipse-margin-right.html This patch reflects changes included in https://code.google.com/p/chromium/issues/detail?id=237568
Attachments
Patch (7.10 KB, patch)
2013-05-14 14:51 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-05-14 14:51:29 PDT
Created attachment 201762 [details] Patch
Dirk Schulze
Comment 2 2013-05-14 16:17:36 PDT
Comment on attachment 201762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201762&action=review r=me. > LayoutTests/fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:73 > + return String( Math.floor(f) ); I don not really like the spaces, but do not care that much about them.
WebKit Commit Bot
Comment 3 2013-05-14 19:17:19 PDT
Comment on attachment 201762 [details] Patch Clearing flags on attachment: 201762 Committed r150097: <http://trac.webkit.org/changeset/150097>
WebKit Commit Bot
Comment 4 2013-05-14 19:17:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.