Bug 115988

Summary:

Unload event listeners should prevent Safari from insta-killing the web process on last tab close

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebKit2

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, gyuyoung.kim

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eflews.bot: commit-queue-
Patch	none
Patch	eflews.bot: commit-queue-
Patch	none

Andreas Kling

Reported 2013-05-12 10:48:31 PDT

<rdar://problem/13870943>

Attachments
Patch (18.10 KB, patch) 2013-05-12 11:56 PDT, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (18.01 KB, patch) 2013-05-12 12:07 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (20.33 KB, patch) 2013-05-12 13:21 PDT, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (19.94 KB, patch) 2013-05-12 13:27 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-05-12 11:56:23 PDT

Created attachment 201501 [details] Patch

WebKit Commit Bot

Comment 2 2013-05-12 11:59:12 PDT

Attachment 201501 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/ChromeClient.h', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebChromeClient.h', u'Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/WebProcessProxy.cpp', u'Source/WebKit2/UIProcess/WebProcessProxy.h', u'Source/WebKit2/UIProcess/WebProcessProxy.messages.in', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h']" exit_code: 1 Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:45: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 3 2013-05-12 12:06:41 PDT

Comment on attachment 201501 [details] Patch Attachment 201501 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/417816

Andreas Kling

Comment 4 2013-05-12 12:07:58 PDT

Created attachment 201503 [details] Patch

Andreas Kling

Comment 5 2013-05-12 13:21:57 PDT

Created attachment 201506 [details] Patch Added Chrome helpers so DOMWindow doesn't have to plumb its way to the ChromeClient. Made DOMWindow think in terms of per-DOMWindow sudden termination instead of globally.

EFL EWS Bot

Comment 6 2013-05-12 13:26:27 PDT

Comment on attachment 201506 [details] Patch Attachment 201506 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/265604

Andreas Kling

Comment 7 2013-05-12 13:27:31 PDT

Created attachment 201507 [details] Patch

WebKit Commit Bot

Comment 8 2013-05-12 16:15:00 PDT

The commit-queue encountered the following flaky tests while processing attachment 201507 [details]: svg/batik/text/smallFonts.svg bug 115040 (author: oliver@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 9 2013-05-12 16:15:51 PDT

Comment on attachment 201507 [details] Patch Clearing flags on attachment: 201507 Committed r149971: <http://trac.webkit.org/changeset/149971>

WebKit Commit Bot

Comment 10 2013-05-12 16:15:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.